Thursday, December 28, 2023

Re: net/syncthing: update to 1.27.1

On Thu, 28 Dec 2023, Edd Barrett wrote:

> On Wed, Dec 27, 2023 at 07:37:36PM +0100, Paco Esteban wrote:
> > Builds and works fine for me on amd64.
> > Most of tests pass. The ones failing are network related which is
> > probably fine, as I use PORTS_PRIVSEP
>
> It's a known issue for the "connections" tests to fail:
> https://github.com/syncthing/syncthing/issues/8421
>
> Is it those?

Pretty similar, but not exactly those.
Here you have them in case they're useful:


2023/12/28 17:55:39 INFO: TCP listener (127.0.0.1:29442) starting
panic: test timed out after 2m0s
running tests:
TestConnectionEstablishment (2m0s)
TestConnectionEstablishment/tcp (2m0s)

goroutine 38 [running]:
testing.(*M).startAlarm.func1()
/usr/local/go/src/testing/testing.go:2259 +0x3b9
created by time.goFunc
/usr/local/go/src/time/sleep.go:176 +0x2d

goroutine 1 [chan receive]:
testing.(*T).Run(0xc000140000, {0xc91dae?, 0xc000223b10?}, 0xcd4d70)
/usr/local/go/src/testing/testing.go:1649 +0x3c8
testing.runTests.func1(0x1313e00?)
/usr/local/go/src/testing/testing.go:2054 +0x3e
testing.tRunner(0xc000140000, 0xc000223c48)
/usr/local/go/src/testing/testing.go:1595 +0xff
testing.runTests(0xc000128820?, {0x1306580, 0xf, 0xf}, {0x418245?, 0xc000223d08?, 0x1312d20?})
/usr/local/go/src/testing/testing.go:2052 +0x445
testing.(*M).Run(0xc000128820)
/usr/local/go/src/testing/testing.go:1925 +0x636
main.main()
_testmain.go:77 +0x19c

goroutine 19 [syscall]:
syscall.syscall6(0x487ee0, 0x3, 0x0, 0x0, 0xc000066718, 0x1, 0x0)
/usr/local/go/src/runtime/sys_openbsd3.go:46 +0x35
syscall.kevent(0x0?, 0x0?, 0x0?, 0x0?, 0x0?, 0x0?)
/usr/local/go/src/syscall/zsyscall_openbsd_amd64.go:271 +0x4e
syscall.Kevent(0x0?, {0x0?, 0x0?, 0x0?}, {0xc000066718?, 0x0?, 0x0?}, 0x0?)
/usr/local/go/src/syscall/syscall_bsd.go:431 +0x35
github.com/syncthing/syncthing/vendor/github.com/syncthing/notify.(*kq).Wait(0x0?)
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/vendor/github.com/syncthing/notify/watcher_kqueue.go:139 +0x46
github.com/syncthing/syncthing/vendor/github.com/syncthing/notify.(*trg).monitor(0xc0001a7230)
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/vendor/github.com/syncthing/notify/watcher_trigger.go:404 +0x35
created by github.com/syncthing/syncthing/vendor/github.com/syncthing/notify.newWatcher in goroutine 1
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/vendor/github.com/syncthing/notify/watcher_trigger.go:112 +0x1f6

goroutine 20 [chan receive]:
github.com/syncthing/syncthing/vendor/github.com/syncthing/notify.(*nonrecursiveTree).dispatch(0xc0001b42a0, 0x0?)
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/vendor/github.com/syncthing/notify/tree_nonrecursive.go:36 +0x45
created by github.com/syncthing/syncthing/vendor/github.com/syncthing/notify.newNonrecursiveTree in goroutine 1
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/vendor/github.com/syncthing/notify/tree_nonrecursive.go:29 +0x145

goroutine 21 [chan receive]:
github.com/syncthing/syncthing/vendor/github.com/syncthing/notify.(*nonrecursiveTree).internal(0xc0001b42a0, 0xc0001b4240)
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/vendor/github.com/syncthing/notify/tree_nonrecursive.go:81 +0x47
created by github.com/syncthing/syncthing/vendor/github.com/syncthing/notify.newNonrecursiveTree in goroutine 1
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/vendor/github.com/syncthing/notify/tree_nonrecursive.go:30 +0x193

goroutine 50 [chan receive]:
testing.(*T).Run(0xc000141520, {0xc88c5b?, 0xd8e188?}, 0xc00010fb90)
/usr/local/go/src/testing/testing.go:1649 +0x3c8
github.com/syncthing/syncthing/lib/connections.TestConnectionEstablishment(0xc000141520)
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/lib/connections/connections_test.go:387 +0xf6
testing.tRunner(0xc000141520, 0xcd4d70)
/usr/local/go/src/testing/testing.go:1595 +0xff
created by testing.(*T).Run in goroutine 1
/usr/local/go/src/testing/testing.go:1648 +0x3ad

goroutine 51 [IO wait]:
internal/poll.runtime_pollWait(0x2ef104d40, 0x77)
/usr/local/go/src/runtime/netpoll.go:343 +0x85
internal/poll.(*pollDesc).wait(0xc0000ee100?, 0xc00039fd00?, 0x0)
/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0x27
internal/poll.(*pollDesc).waitWrite(...)
/usr/local/go/src/internal/poll/fd_poll_runtime.go:93
internal/poll.(*FD).Write(0xc0000ee100, {0xc00039e000, 0x29c8, 0x3000})
/usr/local/go/src/internal/poll/fd_unix.go:388 +0x2d6
net.(*netFD).Write(0xc0000ee100, {0xc00039e000?, 0xc0001c8be0?, 0xbd8de0?})
/usr/local/go/src/net/fd_posix.go:96 +0x25
net.(*conn).Write(0xc0000a8068, {0xc00039e000?, 0xc0001c8be0?, 0xc00039e000?})
/usr/local/go/src/net/net.go:191 +0x45
crypto/tls.(*Conn).write(0xc0000bca80, {0xc00039e000?, 0x5?, 0x3000?})
/usr/local/go/src/crypto/tls/conn.go:944 +0x109
crypto/tls.(*Conn).writeRecordLocked(0xc0000bca80, 0x17, {0xc000300000, 0x20000, 0x20000})
/usr/local/go/src/crypto/tls/conn.go:1025 +0x68e
crypto/tls.(*Conn).Write(0xc0000d8225?, {0xc000300000, 0x20000, 0x20000})
/usr/local/go/src/crypto/tls/conn.go:1232 +0x3f6
github.com/syncthing/syncthing/lib/connections.TestConnectionEstablishment.func1.1({{0xd9e658, 0xc0000bca80}, 0x2, 0x1, 0x0, {0x0, 0xedd1f9f8b, 0x1312d20}, {0x0, 0x0}}, ...)
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/lib/connections/connections_test.go:389 +0x42
github.com/syncthing/syncthing/lib/connections.withConnectionPair({0xd93b20, 0xc0001416c0}, {0xc88c5b, 0x11}, 0xc000337f38)
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/lib/connections/connections_test.go:494 +0xbd9
github.com/syncthing/syncthing/lib/connections.TestConnectionEstablishment.func1(0xc000141520?)
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/lib/connections/connections_test.go:388 +0x6b
testing.tRunner(0xc0001416c0, 0xc00010fb90)
/usr/local/go/src/testing/testing.go:1595 +0xff
created by testing.(*T).Run in goroutine 50
/usr/local/go/src/testing/testing.go:1648 +0x3ad

goroutine 52 [select]:
github.com/syncthing/syncthing/vendor/github.com/thejerf/suture/v4.(*Supervisor).Serve(0xc000124500, {0xd9b318?, 0xc0000365f0?})
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/vendor/github.com/thejerf/suture/v4/supervisor.go:354 +0x45f
github.com/syncthing/syncthing/vendor/github.com/thejerf/suture/v4.(*Supervisor).ServeBackground.func1()
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/vendor/github.com/thejerf/suture/v4/supervisor.go:297 +0x28
created by github.com/syncthing/syncthing/vendor/github.com/thejerf/suture/v4.(*Supervisor).ServeBackground in goroutine 51
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/vendor/github.com/thejerf/suture/v4/supervisor.go:296 +0xb6

goroutine 25 [IO wait]:
internal/poll.runtime_pollWait(0x2ef104e38, 0x72)
/usr/local/go/src/runtime/netpoll.go:343 +0x85
internal/poll.(*pollDesc).wait(0xc0000ee000?, 0x2a22ae?, 0x0)
/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0x27
internal/poll.(*pollDesc).waitRead(...)
/usr/local/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Accept(0xc0000ee000)
/usr/local/go/src/internal/poll/fd_unix.go:611 +0x2ac
net.(*netFD).accept(0xc0000ee000)
/usr/local/go/src/net/fd_unix.go:172 +0x29
net.(*TCPListener).accept(0xc0000c0460)
/usr/local/go/src/net/tcpsock_posix.go:152 +0x1e
net.(*TCPListener).Accept(0xc0000c0460)
/usr/local/go/src/net/tcpsock.go:315 +0x30
github.com/syncthing/syncthing/lib/connections.(*tcpListener).serve(0xc0001d74a0, {0xd9b318, 0xc000180af0})
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/lib/connections/tcp_listen.go:106 +0x888
github.com/syncthing/syncthing/lib/svcutil.(*service).Serve(0xc00020ac00, {0xd9b318, 0xc000180af0})
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/lib/svcutil/svcutil.go:130 +0x85
github.com/syncthing/syncthing/vendor/github.com/thejerf/suture/v4.(*Supervisor).runService.func2()
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/vendor/github.com/thejerf/suture/v4/supervisor.go:565 +0xe6
created by github.com/syncthing/syncthing/vendor/github.com/thejerf/suture/v4.(*Supervisor).runService in goroutine 52
/usr/ports/pobj/syncthing-1.27.1/go/src/github.com/syncthing/syncthing/vendor/github.com/thejerf/suture/v4/supervisor.go:539 +0x1ca
FAIL github.com/syncthing/syncthing/lib/connections 120.142s

--
Paco Esteban.
0x5818130B8A6DBC03

No comments:

Post a Comment