On 2023/12/11 12:40:03 +0000, Stuart Henderson <stu@spacehopper.org> wrote:
> > [...]
>
> Generally looks good to me, couple of small things -
>
> | COMMIT = d9501b220ff59279973bdf53e2ae26bbc27ed7fe
> | DIST_TUPLE = github AZO234 NP2kai ${COMMIT} .
>
> personally I would not use DIST_TUPLE with a commit hash, just stick
> to GH_*, the rename stuff does not work with hashes so you end up
> having to mess about with WRKDIST, which may need undoing if
> DIST_TUPLE gets fixed
Sure, changed back to GH_*
> | HOMEPAGE = https://domisan.sakura.ne.jp/article/np2kai/np2kai.html
> |
> | PERMIT_PACKAGE = Yes
>
> missing license marker
woops :)
Attaching an updated tarball.
No comments:
Post a Comment