Wednesday, December 20, 2023

Re: [NEW]devel/py-anyio

On 2023/12/19 23:14, Lucas Raab wrote:
> On Tue, Dec 19, 2023 at 10:02:13PM +0000, Stuart Henderson wrote:
> > On 2023/12/19 21:46, Lucas Raab wrote:
> > > On Tue, Dec 19, 2023 at 02:49:14PM -0500, Daniel Dickman wrote:
> > > >
> > > >
> > > > > On Dec 19, 2023, at 2:21 PM, Lucas Raab <tuftedocelot@fastmail.fm> wrote:
> > > > >
> > > > > On Fri, Dec 15, 2023 at 07:16:01AM +0000, wen heping wrote:
> > > > >> Hi, ports@:
> > > > >>
> > > > >> Here is a patch to create new port devel/py-anyio,
> > > > >> which is required by the creating of devel/py-httpx,
> > > > >> which is required by some other ports.
> > > > >>
> > > > >> It build well and run well on amd64-current system.
> > > > >> The result of `make test`:
> > > > >> 4 failed, 931 passed, 453 skipped
> > > > >> so many tests skip because of lack of py-uvloop in
> > > > >> our portstree.
> > > > >>
> > > > >>
> > > > >> Cheers !
> > > > >> wen
> > > > >
> > > > > ok lraab@
> > > > >
> > > >
> > > > Actually this cannot be imported as is because it will break my work to add jupyterlab support.
> > > >
> > > > I would be ok with version 3.7.1 though or any version below anyio 4.0.
> > > >
> > > > The constraint on my end is jupyter_server.
> > > >
> > > Hm, I think that would cap an eventual httpx import to 0.25.0 or 0.25.1.
> > > Those should take an httpcore version less than 1.* and httpcore 0.18.0
> > > will accept anyio>=3.0,<5.0. 3.7.1 is the last release before 4.0 for
> > > anyio, as a matter of interest. h11 that wen sent is 0.14.0 which is an
> > > acceptable version for httpcore 0.18.0 as well.
> > >
> > > wen, how does that sound to you?
> > >
> >
> > Sounds alright to me fwiw (slightly annoying, but it is what it is).
> >
> > Please make sure there's a quick note in the Makefile explaining that
> > it's intentionally held back and why.
> >
> Alrighty, how's this look taking that into account?


If I read things correctly, it's anyio that has the tight version spec,
so there should be a mention in there. (However I don't see that reflected
in jupyter_server's pyproject file, which just says anyio>=3.1.0...)

So I'd go for comments like in the attached.

(I removed the patch in www/py-httpcore/patches/patch-pyproject_toml
as well, it's not needed with the hatch-fancy-pypi-readme dep).

No comments:

Post a Comment