On Wed, Dec 20, 2023 at 08:18:30AM +0100, Justin Berthault wrote:
> On Wed, Dec 20, 2023 at 08:09:42AM +0100, Theo Buehler wrote:
> > crates.inc seems to be missing from the diff.
>
> Woops.
>
> Fixed diff attached.
Thanks, committed with this comment (less specific comment means less
churn). It will most likely remain true for the entire 0.17 branch.
# ring-v0.17 does not support this arch
One more change:
-WANTLIB += c c++abi m pthread onig
+WANTLIB += ${MODCARGO_WANTLIB} m onig
On most architectures, rust binaries need 'c c++abi pthread', but it's
different on sparc64 where it is 'c pthread' because it uses libgcc.a.
That's not an issue here since it can't build on sparc64 anyway, but
whenever you see a rust port with hardcoded 'c c++abi pthread' it would
be good fix that.
No comments:
Post a Comment