Monday, February 05, 2024

Re: games/yquake2: enable macppc

On Tue, Feb 06, 2024 at 01:36:58AM +0000, Klemens Nanni wrote:
> On Tue, Feb 06, 2024 at 02:28:34AM +0100, Tobias Heider wrote:
> > Tested and found out it builds and runs fine on macppc.
> >
> > ok to enable it there?
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/games/yquake2/Makefile,v
> > retrieving revision 1.28
> > diff -u -p -r1.28 Makefile
> > --- Makefile 26 Sep 2023 09:41:45 -0000 1.28
> > +++ Makefile 6 Feb 2024 01:17:26 -0000
> > @@ -1,4 +1,4 @@
> > -ONLY_FOR_ARCHS= i386 amd64 sparc64
> > +ONLY_FOR_ARCHS= i386 amd64 sparc64 macppc
> >
> > COMMENT= Yamagi Quake II
> > N= yquake2
> >
>
> Do you want to stick to the whitelist or flip to NOT_FOR_ARCHS?
>
> I'm not interested in this game, just wondered how it came to be that
> architectures support changed.

I wouldn't mind enabling it for all archs either. Not sure which arch it
doesn't work on so NOT_FOR_ARCHS doesn't seem very useful.
I guess if it works on 32 bit BE macppc there is a good chance that most
others work too.

>
> revision 1.4
> date: 2016/06/28 20:50:22; author: awolk; state: Exp; lines: +6 -4; commitid: OCjzSGt5M9IIpgwf;
> Update games/yquake2 5.32 => 5.34
>
> OK abieber@
>
> Changes in the port:
> [...]
> Additional notes:
> [...]
> - upstream said in their changelog that they are changing their
> platform policy 'Switch from an arch whitelist to an "all archs are
> supported" approach.'. I saw in our tree a change by landry@
> specifically limiting the supported platform to the upstream
> supported versions
> (http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/games/yquake2/Makefile?rev=1.2&content-type=text/x-cvsweb-markup).
> I am not removing this restriction until I get some feedback from
> people able to test other platforms than currently
> listed in ONLY_FOR_ARCHS.
>

No comments:

Post a Comment