On Mon, 10 Jun 2024 12:54:52 +0100,
Jeremie Courreges-Anglas <jca@wxcvbn.org> wrote:
>
> On Sun, Jun 09, 2024 at 11:21:58PM +0100, Kirill A. Korinsky wrote:
> I see this in configure.ac:
>
> |## regex support
> |## there are several options
> |## tre is better than regex
>
> I'm not sure what to think about it, but it has to be handled one way
> or the other: currently it's going to be picked up and will cause
> random errors in bulk builds. See proposal below.
>
agreed with your changes.
> > Also, I abit tired from created report.xml by tcpflow when using it with -c
> > and suggested a patch to upstream to avoid that [3] which I've included into
> > updated diff.
>
> Looking at the tool (I don't use it myself) I suspect you could use
> tcpflow -X /dev/null -c. Is this really something where you want to
> deviate from upstream? If so, I can add that patch too (I have
> committed the rest).
More idiomatic way is tcpflow -S enable_report=NO -c (which is the same
thing that my patch does). And yes, I'd like to deviate from upstream
because this is behaviour of tcpflow-0.21 and I expect that this change in
creating a lot of unexpected report.xml after upgrade to 7.6 isn't somehting
expected.
--
wbr, Kirill
No comments:
Post a Comment