Monday, June 03, 2024

Re: [new] audio/pylast: new port (version 5.3.0)

Hi,

Thanks for this.

Some superficial comments below.

On Thu, May 30, 2024 at 12:56:07PM +0100, Kirill A. Korinsky wrote:
> -FLAVORS = python3
> -FLAVOR = python3
> +FLAVORS = python3
> +FLAVOR = python3
>
> -MODULES = lang/python
> +MODULES = lang/python

Next time please send updates without unrelated whitespace changes. It's easier
for us to review this way. Whitespace can be fixed in a follow-up commit.

> +# NOTE: majority of tests require the real access to servers

This doesn't quite parse. How about:

"the majority of the tests require access to real servers"

The rest looks fine, but I (or whoever commits this) should remove me as
MAINTAINER, as I don't use this any more.

Cheers

--
Best Regards
Edd Barrett

https://www.theunixzoo.co.uk

No comments:

Post a Comment