On Tue, 25 Jun 2024, Stuart Henderson wrote:
> > +# jupyter_events needs the "format-nongpl" optional dependencies
>
> could you just add those as deps in jupyter_events instead please?
>
>
I don't think this would work well.
These are optional deps that will really be used by jsonschema if
they are available at runtime. They are not used by jupyter_events.
In fact the current Makefile has a note about running into issues with
idna during dpb junking. And I don't see any reason why the same problem
with dbp junking couldn't happen with all of these other optional
dependencies from my reading of the code. (see jsonschema/_format.py which
does the run-time checking for each of these optional deps)
So I think it would be best to keep them as required deps for jsonschema.
No comments:
Post a Comment