Tuesday, July 30, 2024

Re: [Maintainer update] Add FLAVOR to emulator/minivmac

Thank you! Ok, one issue that I can't quite figure out is when I fake
install, everything seems to go well:

https://okturing.com/src/20483/body

But when I actually try to install both of them, the flavors end up
with collisions:

https://okturing.com/src/20484/body

Would people know why this is happening? I inspected the variables as
well and they seem to be alright to me:

https://okturing.com/src/20485/body

I attached the tarball as well for reference. Thank you.

On Tue, 2024-07-30 at 18:31 +0200, Omar Polo wrote:
> On 2024/07/30 18:18:57 +0200, Omar Polo <op@omarpolo.com> wrote:
> > On 2024/07/30 10:48:58 -0400, Jag Talon <jag@aangat.lahat.computer>
> > wrote:
> > > Attached is my attempt to do that, but when running `make
> > > install` it
> > > seems to install minivmac-36.04 but with the binary for minivmac-
> > > ii-
> > > 36.04.
> >
> > This due to how make evals the variables.  You have
> >
> > : # Macintosh Plus
> > : MODEL =                 -m Plus
> > :
> > : # Macintosh II
> > : .if ${FLAVOR:Mii}
> > : MODEL =                 -m II
> > : SUFFIX =                -ii
> > : .endif
> >
> > so MODEL will always be '-m II'.
>
> sorry, got the values swapped but I was talking trash anyway so
> discard
> this.  using '=' in make overrides previous values, so model is set
> to
> '-m II' iff FLAVOR is ii.
>
> (yet, i believe using ?= or the conditionals is cleaner in these
> cases :P)
>

--
he/him
jagtalon.net
weirder.earth/@jag

No comments:

Post a Comment