Monday, August 26, 2024

Re: net/synapse: fix tests

On Mon, 26 Aug 2024 11:15:00 +0200,
Renaud Allard <renaud@allard.it> wrote:
>
> [1 <text/plain; UTF-8 (base64)>]
>
>
> On 8/25/24 10:01, Landry Breuil wrote:
> >
> > so.. i don't know which is best. Keep using pytest --forked as it's more
> > integrated within the portstree, or run the tests the same way upstream
> > does ?
> >
>
> Let's use the upstream way. This is more future proof as things that
> don't fail now on pytest (or new things) could fail later forcing to
> change that stuff again.

Indeed. Special if it fixes an issue with memory leak.

The only reason why I had used pytest --forked is a simple way to avoid leak.

If other way which is used by upstream is doing the same, it's wise to use it.

--
wbr, Kirill

No comments:

Post a Comment