If it's not needed by any deps then indeed it seems sensible to remove.
Please put REVISION up near GH_TAGNAME, I can pretty much guarantee it will be missed if it's hidden away like that at the bottom of the file!
--
Sent from a phone, apologies for poor formatting.
On 31 October 2024 06:13:25 Rafael Sadowski <rafael@sizeofvoid.org> wrote:
I see no reason why we need lang/clang ${MODCLANG_LIB_DEPENDS} forqtkeychain-qt6. Maybe I missed something, if not OK to remove it?Index: Makefile===================================================================RCS file: /cvs/ports/security/qtkeychain/Makefile,vdiff -u -p -r1.23 Makefile--- Makefile 23 Mar 2024 13:10:57 -0000 1.23+++ Makefile 31 Oct 2024 06:10:15 -0000@@ -31,10 +31,8 @@ FLAVOR ?=.if ${FLAVOR:Mqt6}CONFIGURE_ARGS += -DBUILD_WITH_QT6=ONFULLPKGNAME = qtkeychain-qt6-${GH_TAGNAME}-MODULES += lang/clang x11/qt6-MODCLANG_LANGS += c+++MODULES += x11/qt6WANTLIB += Qt6Core Qt6DBus-LIB_DEPENDS += ${MODCLANG_LIB_DEPENDS}LIBNAME = Qt6KeychainQT = qt6.else@@ -43,6 +41,7 @@ WANTLIB += Qt5Core Qt5DBusLIBNAME = Qt5KeychainQT = qt5.endif+REVISION = 0LIBNAME_L = ${LIBNAME:L}
No comments:
Post a Comment