Re: devel/intellij, devel/pycharm: update to 2024.2.4, add devel/intellij-fsnotifier

On 2024/11/03 12:14, Klemens Nanni wrote:
> 03.11.2024 12:58, Kirill A. Korinsky пишет:
> > @@ -56,5 +57,7 @@ do-install:
> > @ln -s ${TRUEPREFIX}/bin/idea-lightedit \
> > ${PREFIX}/bin/intellij-lightedit
> > ${INSTALL_MAN} ${FILESDIR}/idea.1 ${PREFIX}/man/man1
> > +
> > + @echo "idea.filewatcher.executable.path=${LOCALBASE}/bin/intellij-fsnotifier" >> ${IJ}/bin/idea.properties
>
> Empty lines in targets look off, I don't think we do that.

I have no problem with that. It helps readability sometimes.

Not sure about enabling something that consumes large numbers of FDs by
default though. Do things work ok if the config is added but the dep is
not forced, i.e. "pkg_add this if you want the watcher"?

> > Index: devel/intellij/pkg/PLIST
> > ===================================================================
> > RCS file: /home/cvs/ports/devel/intellij/pkg/PLIST,v
> > diff -u -p -r1.69 PLIST
> > --- devel/intellij/pkg/PLIST 8 Sep 2024 02:15:54 -0000 1.69
> > +++ devel/intellij/pkg/PLIST 3 Nov 2024 09:28:19 -0000
> > @@ -32,7 +32,7 @@ intellij/lib/annotations.jar
> > intellij/lib/app-client.jar
> > intellij/lib/app.jar
> > intellij/lib/bouncy-castle.jar
> > -intellij/lib/build-marker-IC-242.21829.142
> > +intellij/lib/build-marker-IC-242.23726.103
>
> How about something like this to avoid PLIST churn on every update?
>
> SOME_DIST_VER = 242.23726.103
> SUBST_VARS += SOME_DIST_VER
>
> intellij/lib/build-marker-IC-${SOME_DIST_VER}
>
> > intellij/lib/cds/
> > intellij/lib/cds/classesLogAgent.jar
> > intellij/lib/external-system-rt.jar
>
>
> Same for pycharm. Just ideas, though.
>

From experience, doing this with a string that can't be generated from
the version number is annoying for updates (update, make plist, find the
new string, change the Makefile, regenerate plist again). Doesn't seem
worth it when the churn is as small as this (and I stopped doing it even
when the churn is bigger, like in unifi, due to the annoyance).