Re: NEW net/monero

On 2024/11/04 16:58, Lucas Gabriel Vuotto wrote:
> > > + ${INSTALL_DATA} ${WRKBUILD}/lib/libwallet.a ${PREFIX}/lib/
> >
> > is that actually useful? I suggest not unless there's a need for it
>
> If you're talking about libwallet.a, I don't know. Might be useful at
> some point if somebody ports any other Monero wallet, but it's not
> needed for Monero itself.

I suggest not packaging it unless some other port needs it.
Apart from anything else, it's a bit of a generic name.

> > > -daemon_flags="--detach"
> > > +daemon_flags="--detach --config-file ${SYSCONFDIR}/monerod.conf"
> >
> > I'm not going to run this to test, but presumably --detach is a required
> > flag for running as a daemon, so it should go as part of "daemon",
> > leaving the (overridable) --config-file bit in daemon_flags.
>
> Wasn't aware we do that in some rc files.

yep, to make sure that flags which are totally required can't get
overridden. --daemon and so on.

> > /var/db/monero might be better than /var/monero
>
> I don't think so. The DB is ~300GB and /var/db is depended upon by other
> programs. I don't know if and how base could interact with it being in a
> different partition.

oh, that size requirement is definitely worth mentioning somewhere.

On 2024/11/03 14:58, Niklas Hallqvist wrote:
> The old version of monero that I once ported and still run requires an argument like --db-sync-mode=fast:async:10000 to not completely trash the system.
>
> You could try that, and if it still works, mention it as a remedy.

Perhaps even set that by default, either in daemon_flags, or by patching?