Sunday, November 03, 2024

Re: new tool: port-var-check

On Sun, Nov 03, 2024 at 01:08:06PM +0000, Stuart Henderson wrote:
> On 2024/11/03 11:08, Marc Espie wrote:
> > This smaller script tries to match Makefile variables against Makefile.template
> > and reports violation.
> >
> > (manpage should be trivial)
> >
> > (this does not handle include files yet, though I'm not quite sure how
> > to proceed about those)
> >
> > I'm not 100% sure it's something we want, quick poll of landry and aja says
> > "no", but I remember in the past some people insisting about respecting
> > Makefile.template order.
>
> I think this might tend to increase whining about things that don't
> matter, and one can still write a horrible looking Makefile with things
> in the 'right' order ;)
>
> In particular a rigid order makes things less readable for many multi-
> package ports.
>
> > Surprisingly, stuff like REVISION and EPOCH is not in Makefile.template.
>
> Probably because they're never necessary in a new port (i.e. where the
> template is normally used..)
>
>

Though not applicable at the moment, I've had some trouble in the past
getting the requisite okay for a new port, because a few people really
really insisted on Makefile.template order or something similar.

I remember preferring to give up rather than argue, so a checker to quickly
normalize simple ports would help with the drudge.

No comments:

Post a Comment