Re: zstd: enable pzstd

On Tue, Nov 5, 2024 at 3:16 PM Kirill A. Korinsky <kirill@korins.ky> wrote:
>
> On Tue, 05 Nov 2024 00:58:37 +0100,
> Nick Owens <mischief@offblast.org> wrote:
> >
> > diff --git a/archivers/zstd/Makefile b/archivers/zstd/Makefile
> > index 3b6d18883ae..22dca58e7dd 100644
> > --- a/archivers/zstd/Makefile
> > +++ b/archivers/zstd/Makefile
> > @@ -44,6 +44,14 @@ TEST_TARGET = check
> > TESTTMP = ${WRKDIR}/tmp
> > TEST_ENV = TMPDIR=${TESTTMP}
> >
> > +do-build:
> > + ${SETENV} ${MAKE_ENV} ${MAKE_PROGRAM} ${MAKE_FLAGS} -C ${WRKSRC}
> > + ${SETENV} ${MAKE_ENV} ${MAKE_PROGRAM} ${MAKE_FLAGS} -C ${WRKSRC}/contrib/pzstd
> > +
> > +do-install:
> > + ${SETENV} ${MAKE_ENV} ${MAKE_PROGRAM} ${MAKE_FLAGS} -C ${WRKSRC} install
> > + ${SETENV} ${MAKE_ENV} ${MAKE_PROGRAM} ${MAKE_FLAGS} -C ${WRKSRC}/contrib/pzstd install
> > +
>
> I think you need ${_PBUILD} here as well.

i see do-build is invoked as

bsd.port.mk:3065: @${_PMAKE} do-build

and _PMAKE is ${_PBUILD} ${MAKE} if ${PORTS_PRIVSEP}

pkgpath.mk:138:_PMAKE = cd ${.CURDIR} && PKGPATH=${PKGPATH} exec
${_PBUILD} ${MAKE}

so won't ${_PBUILD} be added automatically as needed? if i
misunderstood, i can still send a new patch to add it.

>
> --
> wbr, Kirill