Re: maintainer update net/gajim --> 1.9.5

On Tue, Dec 17, 2024 at 07:08:10PM +0100, Paco Esteban wrote:
> Lucas Gabriel Vuotto <lucas@sexy.is> writes:
>
> > On Mon, Dec 16, 2024 at 07:07:19PM +0100, Paco Esteban wrote:
> >> Updated diff with py-gstreamer added as a RDEP.
> >> Without it we encounter all sorts of crashes.
> >>
> >> Tried to apply a patch that's already in master,
> >> https://dev.gajim.org/gajim/gajim/-/commit/d3f0067f8ad5a36ad6a7f5163767b34e72257b2d
> >> as suggested by lucas@ but the problem persist.
> >>
> >> We can get ride of gstreamer in a future version.
> >>
> >> comments ? ok ?
> >
> > I'm able to run Gajim withour gstreamer with this patch.
>
> Still crashes for me with this patch without py3-gstreamer installed:
>
> ## Versions:
> - OS: OpenBSD 7.6
> - GTK Version: 3.24.43
> - PyGObject Version: 3.50.0
> - GLib Version : 2.82.4
> - libsoup Version: 3.6.1
> - python-nbxmpp Version: 5.0.4
> - Gajim Version: 1.9.5
>
> ## Traceback
> ```
> Traceback (most recent call last):
> File "/usr/local/lib/python3.11/site-packages/gajim/gtk/application.py", line 382, in _handle_local_options
> self._startup()
> File "/usr/local/lib/python3.11/site-packages/gajim/gtk/application.py", line 263, in _startup
> MainWindow()
> File "/usr/local/lib/python3.11/site-packages/gajim/gtk/main.py", line 98, in __init__
> self._main_stack = MainStack()
> ^^^^^^^^^^^
> File "/usr/local/lib/python3.11/site-packages/gajim/gtk/main_stack.py", line 29, in __init__
> self._chat_page = ChatPage()
> ^^^^^^^^^^
> File "/usr/local/lib/python3.11/site-packages/gajim/gtk/chat_page.py", line 51, in __init__
> self._chat_stack = ChatStack()
> ^^^^^^^^^^^
> File "/usr/local/lib/python3.11/site-packages/gajim/gtk/chat_stack.py", line 77, in __init__
> self._message_action_box = MessageActionsBox()
> ^^^^^^^^^^^^^^^^^^^
> File "/usr/local/lib/python3.11/site-packages/gajim/gtk/message_actions_box.py", line 86, in __init__
> self.voice_message_recorder_button = VoiceMessageRecorderButton()
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/usr/local/lib/python3.11/site-packages/gajim/gtk/voice_message_recorder_widget.py", line 51, in __init__
> self.set_child(
> ^^^^^^^^^^^^^^
> AttributeError: 'VoiceMessageRecorderButton' object has no attribute 'set_child'
>
> ```

My bad. I had gstreamer installed while trying this patch. :(
(it got pulled by py3-qt5 and forgot about it.)

After a 'pkg_delete gstreamer1', I run into the same issue. The reason
is that set_child was added to Gtk.MenuButton on GTK 4.6 [0]. A lot of
the code in master since 1.9.5 includes migrations to GTK 4.

It's probably best to stick with py3-gstreamer RDEP and revisit the
thing on a new release.

[0]: https://docs.gtk.org/gtk4/method.MenuButton.set_child.html