Re: fcitx batch updates: new patch

On 2025/01/01 21:32, Kevin Lo wrote:
> On Tue, Dec 24, 2024 at 09:29:26AM +0000, Yifei Zhan wrote:
> >
> > On 24/12/23 01:51PM, Stuart Henderson wrote:
> > > On 2024/12/23 05:37, Yifei Zhan wrote:
> > > > On 24/12/22 11:28PM, Yifei Zhan wrote:
> > > > > On 24/12/22 03:33AM, Yifei Zhan wrote:
> > > > > > Here is another wave of opencc and fcitx-* updates.
> > > > > >
> > > > >
> > > > > The patch attached to the last email contains a few mistakes due to a
> > > > > merge error from my workflow, a new patch is being prepared.
> > > > >
> > > > > Thanks Brad Smith for noticing this and sorry for the noise.
> > > > >
> > > >
> > > > New patch, this should apply properly now. ;)
> > >
> > > This patch adds DIST_SUBDIR to some ports and removes it from others,
> > > could you make them consistent please? (It doesn't matter too much
> > > which way, but my personal preference is to avoid DIST_SUBDIR unless
> > > the filenames don't include versions and result in conflicts).
> >
> > New patch attached, thanks for noticing that. My goal is to get rid of alL
> > the DIST_SUBDIR but some got mixed in during another merging process.
>
> Thanks for your work. Quickly testing your patch, I noticed that installing
> inputmethods/fcitx-config-qt displayed an issue, while the rest of the ports
> had no problems.
>
> ===> Building package for fcitx-configtool-5.1.7
> Create /usr/ports/packages/amd64/all/fcitx-configtool-5.1.7.tgz
> LIB_DEPENDS x11/qt5/qtx11extras not needed for inputmethods/fcitx-config-qt ?
> LIB_DEPENDS devel/kf6/kdeclarative not needed for inputmethods/fcitx-config-qt ?
> LIB_DEPENDS devel/kf5/plasma-framework not needed for inputmethods/fcitx-config-qt ?
> LIB_DEPENDS devel/kf5/kdeclarative not needed for inputmethods/fcitx-config-qt ?
> LIB_DEPENDS devel/kf5/ki18n not needed for inputmethods/fcitx-config-qt ?
> LIB_DEPENDS devel/kf5/kitemviews not needed for inputmethods/fcitx-config-qt ?
> LIB_DEPENDS x11/qt5/qtbase,-main not needed for inputmethods/fcitx-config-qt ?

This means that there's no WANTLIB entry associated with the LIB_DEPENDS
entry, so the dependency is *not* recorded in the package.