On Wed, Jan 01 2025, Thomas Frohwein wrote:
> On Wed, 1 Jan 2025 09:28:29 -0500
> Thomas Frohwein <tfrohwein@fastmail.com> wrote:
>
>> On Wed, 25 Dec 2024 12:27:44 +0200
>> Timo Myyrä <timo.myyra@bittivirhe.fi> wrote:
>>
>> [...]
>>
>> > -GH_TAGNAME = 1.1.9
>> > +GH_TAGNAME = 1.1.14
>> >
>> > -SHARED_LIBS += zmusic 1.0 # 1.1.0
>> > -SHARED_LIBS += zmusiclite 1.0 # 1.1.0
>> > +SHARED_LIBS += zmusic 1.1 # 1.1.14
>> > +SHARED_LIBS += zmusiclite 1.1 # 1.1.14
>>
>> Running /usr/src/lib/check_sym on both shared libs, there are removed
>> symbols and data object size changes, so to me it looks like this
>> needs a major bump for both...
>
> I missed to include the major bump, now included in the attached diff.
>
>>
>> [...]
>>
>> $ make port-lib-depends-check
>>
>> zmusic-1.1.14(audio/zmusic):
>> Missing: glib-2.0.4201 from glib2-2.82.4
>> (/usr/local/lib/libzmusiclite.so.1.1) Extra: fluidsynth.3 z.7
>> WANTLIB += glib-2.0
>>
>> Per the logs, it builds the bundled fluidsynth (under thirdparty/). So
>> I'm not sure the WANTLIB or LIB_DEPENDS are correct, unless some other
>> work is done to use fluidsynth from our port...
>>
>> The CONFIGURE_ARGS for -DDYN_FLUIDSYNTH=NO doesn't seem to do anything
>> - there is nothing in the source that matches this.
>>
>> And it probably uses thirdparty/miniz instead of system zlib...
>>
>> Here is a diff that cleans this up and make port-lib-depends-check is
>> happy now. Can you check if it looks correct from your side?
Yeah, I took a more closer look at this and the changes look good.
This compiles and runs nicely with the updated gzdoom port.
timo
No comments:
Post a Comment