Le Fri, Feb 28, 2025 at 07:11:13PM +0100, Volker Schlecht a écrit :
> Alright, so here goes my next attempt, addressing
>
> On 2025-02-28 18:11, Jeremie Courreges-Anglas wrote:
> [...]
> > I'd rather patch out the hidden dep so that the build is
> > deterministic, even on a machine where jimtcl is already installed.
>
> > I know you're not responsible for the current situation, but IMHO
> > those "for this" "andinitially for that" comments don't bring much
> > value . One can look at cvs blame/log to understand why we enabled an
> > option. I don't feel too strongly about it but the Makefile would be
> > more readable if we merged CONFIGURE_ARGS in a single block.
>
> More than happy to do that. I just noticed after the commit that I added the
> flag enabling the session extension into the block marked "for mozilla", which
> just proves your point.
the "for mozilla" section was useless anyway, since
https://bugzil.la/1611386 (firefox 75, 5 years ago) --with-system-sqlite
was dropped so all the mozillas use their bundled sqlite with own custom
options.
+1 for CONFIGURE_STYLE=simple :)
Landry
No comments:
Post a Comment