Re: [Update] shells/fish 4.0.0

Am Sun, 2 Mar 2025 14:20:01 +0000
schrieb Stuart Henderson <stu@spacehopper.org>:

> On 2025/02/28 21:21, Florian Viehweger wrote:
> > Am 28. Februar 2025 18:29:42 UTC schrieb Volker Schlecht
> > <openbsd-ports@schlecht.dev>:
> > >On 2025-02-28 17:54, Florian Viehweger wrote:
> > >
> > >> Thank you for beating me to it. I've modified your version, most
> > >> tests are working now. According to this[1] post, cmake doesn't
> > >> allow a custom target with the name "test" anymore.
> > >
> > >Good catch!
> > >
> > >> Comments?
> > >
> > >I need to apologize - I just re-read your mail after checking your
> > >diff, and committing under the assumption that you ok'ed the diff
> > >with your additions. I only just now realized that you didn't
> > >actually ok.
> >
> > I'm fine with it, sorry for not stating it clearer.
> >
> > However I'm not in the position to give an actual OK. These should
> > only be given by OpenBSD developers which I am not.
>
> If a port maintainer approves of a change, we would
> usually write 'ok maintainer' or similar in the commit message.
>

Thank you for clarifying, I'll keep that in mind.

--
greetings,

Florian Viehweger