Re: [Update] shells/fish 4.0.0

Am Mon, 24 Mar 2025 12:05:08 +0000
schrieb Stuart Henderson <stu@spacehopper.org>:

> On 2025/03/23 22:59, Florian Viehweger wrote:
> > Am Fri, 21 Mar 2025 16:00:03 +0000
> > schrieb Stuart Henderson <stu@spacehopper.org>:
> >
> > > On 2025/03/03 22:32, Florian Viehweger wrote:
> > > > Am Sun, 2 Mar 2025 14:14:59 +0000
> > > > schrieb Stuart Henderson <stu@spacehopper.org>:
> > > >
> > > > > I do think we need to do _something_ with this, because as
> > > > > things stand, if an i386 user has fish as their shell, they
> > > > > will be left with old binaries which will stop working
> > > > > sometime. If not going for this approach then we'll need
> > > > > something in current.html / release notes so that people can
> > > > > change their user's shell in advance of upgrading.
> > > >
> > > > I like the proposal splitting fish into v3 and v4. Within this
> > > > week I'll prepare a diff and send it to ports@.
> > > >
> > > > Thanks again for the idea!
> > >
> > > If we don't get something for this soon, it will be too late for
> > > release and we'll need to go with the warning and hope people read
> > > release notes ;)
> >
> > I've made the suggested changes, however I'm missing something here.
> >
> > According to the documentation only 'main' should be built without
> > arguments. However both versions are built. What am I doing wrong
> > here?
>
> Which documentation?
https://www.openbsd.org/faq/ports/ports.html#PortsFlavors

* Summary: Some ports are split into several packages. make install will
only install the main subpackage.

To me this approach in fish seems to me like a subpackage, so I
presumed that it would be handled the same.

> These are separate ports, if you are in shells/fish and type "make"
> then it will simply recurse to v3 and main, this is expected.

> It is expected that both versions will be built; the fiddly bit is
> the placement of the "@pkgpath shells/fish" marker in the PLIST so
> that pkg_add -u works as expected.
>
> Tweaked version attached.
>
> What's the purpose of the gnugetopt run dependency? It doesn't seem
> to be used in either v3 or v4..

From what I've seen it is (or was) used to parse long arguments. I did
some testing and tests behave the same without the gnugetopt run
dependency.

As release is approaching, I'd like to remove the dep from the port
after unlock. I don't want to unknowingly break something for some
users.

Thank you for already importing the split fish package.

I've seen that the package is not available in i386 snapshots right now.
I hope this is due the timing of bumping a base lib and the timing of
the build process of the i386 packages. I'll investigate once new
snapshot packages are on the mirrors.

Thanks again!

--
greetings,

Florian Viehweger