Thursday, May 29, 2025

Re: pgpool-II: Update to 4.6.0

I don't use this but the diff looks sane.

It would be good to add a comment to the head of
patch-src_utils_json_writer_c with a reference to the upstream
commit, it's usual to just include the git patch header e.g.

From 14c94473b5b59429186d8c65407bcce17a20cf99 Mon Sep 17 00:00:00 2001
From: Bo Peng <pengbo@sraoss.co.jp>
Date: Thu, 1 May 2025 11:36:55 +0900
Subject: [PATCH] Fix json_writer did not properly encode special characters.

Don't hold your breath waiting for a reply from the maintainer ;)


On 2025/05/29 17:56, Martijn van Duren wrote:
> ping
>
> On Fri, 2025-05-02 at 15:28 +0200, Martijn van Duren wrote:
> > Hello ports@,
> >
> > I'm currently experimenting with a setup where I expect to be using
> > pgpool-II. It appears that everything works as expected with the
> > update below. The only thing that doesn't seem to work is the new
> > wd_monitoring_interfaces_list functionality, for which I don't see
> > a direct need for my own setup and which probably needs some
> > OpenBSD specific code.
> >
> > The json_writer.c bit is a bug I hit and got accepted upstream[0]
> >
> > OK?
> >
> > martijn@
> >
> > [0] https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=14c94473b5b59429186d8c65407bcce17a20cf99
> >
> > diff /usr/ports
> > path + /usr/ports
> > commit - 0fbcf24b3e32197a3a763c2c08e4480204b0b998
> > blob - 7b727f2f1bf26c69a4dc850af2467de70dc34498
> > file + databases/pgpool/Makefile
> > --- databases/pgpool/Makefile
> > +++ databases/pgpool/Makefile
> > @@ -1,7 +1,6 @@
> > COMMENT= connection pool server for PostgreSQL
> >
> > -DISTNAME= pgpool-II-3.7.18
> > -REVISION= 1
> > +DISTNAME= pgpool-II-4.6.0
> >
> > CATEGORIES= databases
> >
> > commit - 0fbcf24b3e32197a3a763c2c08e4480204b0b998
> > blob - 20e05c1a006ebc4e5571c61db88536c1b0fbd841
> > file + databases/pgpool/distinfo
> > --- databases/pgpool/distinfo
> > +++ databases/pgpool/distinfo
> > @@ -1,2 +1,2 @@
> > -SHA256 (pgpool-II-3.7.18.tar.gz) = 0I4zuZYUjHukHw5PWjMLU5Ec1srJTHh3gIewaMjaCX4=
> > -SIZE (pgpool-II-3.7.18.tar.gz) = 3447131
> > +SHA256 (pgpool-II-4.6.0.tar.gz) = 9oplcUQtfqU7afOddJrUV3kLABgOGbAZ/ILiNbqwcyE=
> > +SIZE (pgpool-II-4.6.0.tar.gz) = 5396128
> > commit - 0fbcf24b3e32197a3a763c2c08e4480204b0b998
> > blob - /dev/null
> > file + databases/pgpool/patches/patch-src_include_utils_fe_ports_h (mode 644)
> > --- /dev/null
> > +++ databases/pgpool/patches/patch-src_include_utils_fe_ports_h
> > @@ -0,0 +1,11 @@
> > +Index: src/include/utils/fe_ports.h
> > +--- src/include/utils/fe_ports.h.orig
> > ++++ src/include/utils/fe_ports.h
> > +@@ -28,6 +28,7 @@
> > + #error "This file is not expected to be compiled for pgpool utilities only"
> > +

No comments:

Post a Comment