Re: [update] comms/amtterm

On Mon, Sep 01, 2025 at 02:48:06PM +0200, Jeremie Courreges-Anglas wrote:
> On Mon, Sep 01, 2025 at 09:40:02AM +1000, Jonathan Gray wrote:
> > On Sun, Aug 31, 2025 at 10:53:09PM +0200, Jeremie Courreges-Anglas wrote:
> > > Here's an update to the latest amtterm-1.7 release from 2022. It
> > > drops most of the SSL/auth etc diffs backported from
> > > https://github.com/Openwsman/wsmancli/
> > >
> > > There's also a new tool called amtider (for floppy or CDROM
> > > redirection) that might come in handy, it needed a few patches but I
> > > haven't tested it. I've put this in the -term subpackage because it
> > > doesn't have any dep, but I can move it back to -main.
> > >
> > > I doubt this will change anything to the disconnections I get when
> > > booting my T14 Gen 3 - will test that later.
> > >
> > > Test reports & oks welcome.
> >
> > still works with x250 ThinkPad (Intel ME v10.0.55.3000)
> >
> > noticed the following while building:
> >
> > redir.c:415:35: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
> > 415 | r->seqno & 0xff, (r->seqno >> 8) && 0xff,
> >
>
> Yup, fix looks obvious, updated diff below. Also fixes a logic error
> in the patch that replaces signalfd.

thanks, still works here

ok jsg@