Re: new multimedia/dms

28.10.2025 23:02, Igor Zornik пишет:
> Hello, fellow DLNA enthusiast,
>
> Tried this on an amd64 system, but used minidlna's UID for reviewing
> purposes. It works and plays videos in VLC just fine. Unfortunately my
> semi-ancient Sony TV doesn't pick it up, but I suppose that's a
> separate issue. My comments:

Same here: different appliance only sees MiniDLNA, not dms.

>
> Is it really necessary to complicate the port with patches? It builds
> and runs just fine without them and for any nonessential features from
> the upstream we can just wait for a new release.

Yes, the whole point of this port is to have DLNA in an IPv6-only network
and without the patches it doesn't work.

> It doesn't pass lib-depends; missing c and pthread.
>
> Missing homepage.

Thanks.

>
> DESCR isn't fmt-ed. Portcheck doesn't complain, so maybe it isn't
> relevant, but it's nice to keep things consistent.

I just copied it verbatim and only made sure that it fits in 80 chars
while breaking after full stops and commas to change as little as needed.

>
> RC is string replacing invalid characters. Wouldn't it be more
> appropriate to escape them? Or just remove it altogether as setting the
> values is supported through the configuration file.

This is only needed for pgrep(1) to not treat [ipv6-addr]:port as
character class; instead of turning [ into . it could prepend \
and work equally fine, the current approach was chosen for brevity.

If there's any problem with that or we find a better/shorter solution,
I'm all ears.

> Readme with instructions for basic setup, usage, and default values
> probably wouldn't hurt.

Is that really needed? Imho, you need to things: a listen socket and
a directory to serve. Both is entirely user-specific, i.e. I don't see
sane defaults to provide.

If you don't know what dms is, read the website or command usage.

Perhaps a note on the directory having to be readable by the user,
but that should go without saying and I doubt we spell out these
things in other ports.

>
> I've attached the port with most of my suggestions implemented.
I don't think it's worth providing a default config file as dms can be
fully configured without one using just command line flags.

So here's a tarball with just HOMEPAGE, WANTLIB and your DESCR added.

Feedback? OK?

Index: user.list
===================================================================
RCS file: /cvs/ports/infrastructure/db/user.list,v
diff -u -p -r1.473 user.list
--- user.list 19 Oct 2025 16:23:20 -0000 1.473
+++ user.list 19 Oct 2025 16:23:55 -0000
@@ -104,7 +104,7 @@ id user group port
593 _gotwebd _gotwebd devel/got,-webd
594 _ejabberd _ejabberd net/ejabberd
595 _poppassd _poppassd sysutils/openpoppassd
-#596 _heartbeat _heartbeat sysutils/heartbeat
+596 _dms _dms multimedia/dms
597 _spotifyd _spotifyd audio/spotifyd
598 _iodine _iodine net/iodine
599 _bacula-sd sysutils/bacula