On Sun, Jan 04, 2026 at 01:04:01PM +0100, Rafael Sadowski wrote:
> Since we do not provide KERN_PROC_PATHNAME I picked up robets@'s "hack"
> form www/chromium/patches/patch-base_base_paths_posix_cc.
>
> It certainly won't work in all cases, but it's enough for me in this context.
> This implementation only makes sense if we don't call it too often.
>
> Is KERN_PROC_PATHNAME something we generally don't want? Or was it
> simply not implied?
We don't know the path to a vnode, now we could store the path in the
kernel but a directory in that path could be moved and replaced. Or a
symlink changed or the text file could be removed, ... So there is a lot
of things that can go wrong. In all of these cases KERN_PROC_PATHNAME
needs to return an error.
On top of all of this do those application using this sysctl even consider
a failure of this call?
> Index: kwin/Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/kde-plasma/kwin/Makefile,v
> diff -u -p -r1.41 Makefile
> --- kwin/Makefile 4 Jan 2026 09:12:01 -0000 1.41
> +++ kwin/Makefile 4 Jan 2026 11:55:27 -0000
> @@ -1,6 +1,6 @@
> COMMENT = Wayland window manager for KDE Plasma Desktops
> DISTNAME = kwin-${VERSION}
> -REVISION = 2
> +REVISION = 3
>
> SHARED_LIBS += kcmkwincommon 1.0 # 0.0
> SHARED_LIBS += kwin 1.0 # 0.0
> Index: kwin/patches/patch-src_utils_executable_path_sysctl_cpp
> ===================================================================
> RCS file: /cvs/ports/x11/kde-plasma/kwin/patches/patch-src_utils_executable_path_sysctl_cpp,v
> diff -u -p -r1.1 patch-src_utils_executable_path_sysctl_cpp
> --- kwin/patches/patch-src_utils_executable_path_sysctl_cpp 4 Jan 2026 08:03:42 -0000 1.1
> +++ kwin/patches/patch-src_utils_executable_path_sysctl_cpp 4 Jan 2026 11:55:27 -0000
> @@ -2,11 +2,103 @@ https://invent.kde.org/plasma/kwin/-/mer
> Index: src/utils/executable_path_sysctl.cpp
> --- src/utils/executable_path_sysctl.cpp.orig
> +++ src/utils/executable_path_sysctl.cpp
> -@@ -12,11 +12,13 @@
> +@@ -7,16 +7,105 @@
> + #include <sys/param.h>
> + #include <sys/sysctl.h>
> + #include <sys/types.h>
> ++#if defined(__OpenBSD__)
> ++#include <QDebug>
> +
> ++#include <kvm.h>
> ++#include <limits.h>
> ++#include <stdlib.h>
> ++#include <string.h>
> ++#include <sys/stat.h>
> ++#include <unistd.h>
> ++
No comments:
Post a Comment