Re: net/syncthing: fix hard-coded paths in patch

02.01.2026 02:53, Edd Barrett пишет:
> Hi,
>
> On Thu, Jan 01, 2026 at 11:47:15PM +0000, Klemens Nanni wrote:
>>> -+ if err := unix.Unveil("/usr/local/bin/syncthing", "rx"); err != nil {
>>> ++ if err := unix.Unveil("${PREFIX}/bin/syncthing", "rx"); err != nil {
>>
>> This would be right,
>>
>>> + panic(err)
>>> + }
>>> +
>>> -+ if err := unix.Unveil("/usr/local/bin/xdg-open", "rx"); err != nil {
>>> ++ if err := unix.Unveil("${LOCALBASE}/bin/xdg-open", "rx"); err != nil {
>>
>> this, however should be LOCALBASE, see bsd.port.mk(5).
>
> Read again. It is LOCALBASE :)

Yikes, I read the first line and skimmed the second only for the program's name...

>
>> That goes to show that you're off the rails and on your own
>> as soon as you build ports with anything other than /usr/local/.
>
> I'd be amazed if anyone's ever changed their install location too.
>
> Cheers
>

That said, using variables doesn't hurt and is probably more consistent.
I'm sure there are other ports hardcoding this, but they're a minority.