Tuesday, January 06, 2026

Re: [NEW] cad/xnec2c

Le 05/01/2026 à 16:34, Stuart Henderson a écrit :
> On 2026/01/05 15:21, Enzo Nicosia wrote:
>> On Tue, Dec 30, 2025 at 11:36:32AM +0000, Stuart Henderson wrote:
>>> tgz with tweaks attached;
>>>
>>
>> Hello Stuart, and thanks again.
>>
>>> - don't use github autogenerated tar when upstream has an uploaded one
>>
>> OK.
>>
>>> - use standard location for examples (I couldn't figure out where
>>> install is done in the makefiles to adjust directly, so just mv'd
>>> into place)
>>
>> I guuess your solution of mobing them in place in post-install is best,
>> as the patches to the Makefile.am could be cumbersome and error-prone
>> (upstream maintains a list of examples that are allowd with the current
>> version, appaarently).
>>
>>> - don't list ports as LIB_DEPENDS unless they're used directly
>>> (e.g. libraries only used as deps of gtk+3)
>>
>> got that, thanks.
>>
>>> - small ordering/whitespace tweaks
>>>
>>
>> Those are fine by me. Can I ask if there is a specific reason for having
>> space rather than TAB after WANTLIB += ? I think I had used TAB
>> consistently for all the other variables (I get and accept your point
>> about aligning and ordering, thanks), but I wonder if WANTLIB is somehow
>> different? Or += is somehow different? Sorry if I am missing something
>> moot here.
>
> we usually copy and paste these from "make port-lib-depends-check"
> without reformatting
>
>> New tgz attached. It is the same you sent me, where I have removed
>> Makefile- (the old Makefile).
>>
>> Is this OK?
>
> ok with me if someone would like to import
>

Imported, thanks !

No comments:

Post a Comment