Hi,
On Thu, Jan 01, 2026 at 05:12:57PM +0000, Douglas Silva wrote:
> I've come up with a simpler patch by adding a conditional
> to the startup script in 'lib/syncthing/syncthing.go'.
> This way, the nag screen isn't deleted from the code, but
> it won't ever nag you as long as you don't change the
> setting back to "Undecided".
>
> But think about it: usage collection is disabled by default
> on stable releases. The web GUI merely asks if you'd like
> to enable it; and if you choose "No", it should remain
> disabled. So why are we even patching this?
If you look at the CVS log for patch-lib_build_build_go, then we see that the
"kill phone home" change was committed by job@, perhaps in agreement with kn@.
If you want to change that behaviour, you'd have to take it up with them.
Personally I don't mind it asking on first run, but if other developers object,
then we will keep it. I'm not touching this for now.
(You also have to bear in mind that at the time that patch was introduced, the
behaviour may not have been to ask. No idea)
FWIW, your change to set it to disabled by default works for me.
> I've also removed the patch file 'patch-lib_build_build_go'.
> It wasn't really needed, as we will never ship release candidates
> here.
We have done in the past. I'm happy to remove that patch for now.
I've committed the update. Thanks.
--
Best Regards
Edd Barrett
https://www.theunixzoo.co.uk
No comments:
Post a Comment