Re: Upgrade net/syncthing to v2

Hi again,

Sorry to continue the syncthing saga, but:

On Thu, Jan 01, 2026 at 10:26:27PM +0000, Edd Barrett wrote:
> If you look at the CVS log for patch-lib_build_build_go, then we see that the
> "kill phone home" change was committed by job@, perhaps in agreement with kn@.
>
> If you want to change that behaviour, you'd have to take it up with them.
> Personally I don't mind it asking on first run, but if other developers object,
> then we will keep it. I'm not touching this for now.

Thinking about this some more, I wonder if we misunderstood the intent of
patch-lib_build_build_go.

The log message for the commit that added the patch says:

```
Unbreak syncthing, update to 1.23.2rc1, disable phone-home
```

so that patch was introduced *as part of an update to a release candidate*.

And in build.go, there's a comment:

```
// Release candidate builds are also "betas" from this point of view and
// will have that debugging enabled. In addition, some features are
// forced for release candidates - auto upgrade, and usage reporting.
```

In light of this, looks like the intent of the patch was not to disable
syncthing from asking for permission to send usage reports, but instead to
disable *unconditionally sending usage reports in release candidates*.

kn@, job@ -- is that correct? We don't mind syncthing asking for permission to
send usage reports?

If asking is fine, we can simplify what I committed yesterday slightly:

- remove the patch that disables asking.

- optionally: put back patch-lib_build_build_go, just in case we ever package
a release candidate again in the future.

Cheers

--
Best Regards
Edd Barrett

https://www.theunixzoo.co.uk