Thanks. I wonder if we could do it more simply, I might take a look at
that later, but anyway OK for now. Nice to have tests enabled to give
a bit more confidence when updating libdispatch.
On 2026/01/31 11:58, Sebastian Reitenbach wrote:
> Hi,
>
> On Fri, Jan 30, 2026 at 3:55 PM Stuart Henderson <stu@spacehopper.org> wrote:
>
> On 2026/01/27 15:59, Sebastian Reitenbach wrote:
> > Hi,
> >
> > just pinging for feedback. Patches reattached.
>
> the newly added "test" target is problematic. firstly, as it doesn't
> do what "make test" is expected to do, it should probably not override
> that. if the normal upstream build infrastructure can't be used (i.e.
> -DTESTS=On and fix whatever is causing it to fail) then it should use
> a different name ("build-tests" or something?) with a comment explaining
> it. or convert to do-test and have it also run the tests. also it needs
> to use ${WRKBUILD} rather than just whatever that happens to expand to
> on your system.
>
>
>
> as you mentioned the -DTESTS=On I got the idea to mimic what configure and build stage do
> in the test stage, and enable the tests. It finally built them, but still didn't ran them. But
> then
> I stumbled upon ctest, calling this at the end of test stage, was the missing piece.
> 5 out of 98 tests fail. I used same approach with older version, but there all test fail
> (subprocess aborted).
>
> I run this since weeks, but didn't experience any trouble yet, even with those 5 filed tests.
>
> Updated diff attached.
>
> Sebastian
>
>
>
>
> > thank you,
> > Sebastian
> >
> > On Mon, Jan 19, 2026 at 9:50 AM Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
> wrote:
> >
> > Hi,
> >
> > this updates libobjc2 to 2.3. This version allows, to not use internal libdispatch,
> but
> > build/link against external libdispatch. To build, it requires private headers,
> therefore
> > the BUILD_DEPENDS on the :patch target, as sthen@ suggested.
> >
> > Being finally able to use libdispatch in objective-c is kind of the last missing
> modern
> > objective-c feature.
> >
> > Getting the tests to work, caused me some grief, but I got most of then to build now.
> > However, it would still need to run them.I left it in that state now, as they can be
> run
> > manually. Some are failing, but up to now, I haven't seen any issues yet.
> > It may well be that they would have failed with the previous versions as well.
> >
> > See attached libobjc2.diff
> >
> > Additionally, updated gnustep.port.mk accordingly, and took the opportunity to clean
> > WANTLIB on a number of depending ports.
> >
> > See attached gnustep.diff
> >
> > Works for me on amd64 for about 2 months now.
> >
> >
> > cheers,
> > Sebastian
> >
> >
>
>
>
>
No comments:
Post a Comment