That's fine with me.
--
Sent from a phone, apologies for poor formatting.
On 18 February 2026 17:06:49 Kurt Miller <kurt@intricatesoftware.com> wrote:
On Feb 18, 2026, at 9:25 AM, Stuart Henderson <stu@spacehopper.org> wrote:On 2026/02/18 13:10, Kurt Miller wrote:I need this to improve the ghidra port. Ghidra needs protobuf, py-protobufand protobuf-java to be the same version (or at least close enough theyare compatible with each other). Currently ghidra has a build depend onprotobuf and a run depend on py-protobuf and I patched ghidra so thesupplemental distfile downloads protobuf-java. The problem with thisapproach is that when the system protobuf is incremented to a versionthat is not compatible with the protobuf-java in the distfile, theghidra supplemental distfile must be rerolled.The better approach is to have a protobuf-java port that is kept insync with the rest of the protobuf port versions and have ghidra useit. This will allow me to fix the current brittle setup and allowprotobuf to be updated without requiring either a new supplementalghidra distfile or for ghidra needing to be bumped every time protobufversion changes.okay?ok to import.do we want some comment in devel/protobuf about keeping the othersin sync (and ideally info on how to check if they're close enough?)Before tb@ went on vacation he mentioned to me off-list that heupdates protobuf and py-protobuf at the same time. So this wouldbe another to keep in sync with protobuf. Just to be clear when Isaid same version I was referring to the PROTOBUF_VERSION part ofthe version. A comment does make sense. How does this look?# Keep PROTOBUF_VERSION in devel/py-protobuf and devel/protobuf-java# in sync with this port.-Kurt
No comments:
Post a Comment