Sunday, February 01, 2026

Re: NEW: games/fallout1-ce -> 1.1.0 && games/fallout2-ce -> 1.3.0

On Sat, 10 Jan 2026 21:56:18 -0600
izzy Meyer <izder456@disroot.org> wrote:

> On Sat, 10 Jan 2026 15:39:33 -0800
> Thomas Frohwein <tfrohwein@fastmail.com> wrote:
>
> > On Fri, 09 Jan 2026 20:28:40 +0100
> > Kirill A. Korinsky <kirill@korins.ky> wrote:
> >
> > > On Thu, 08 Jan 2026 23:18:57 +0100,
> > > Thomas Frohwein <tfrohwein@fastmail.com> wrote:
> > > >
> > > > PS: there is a precedent: games/devilutionx also has Sustainable
> > > > Use License 1.0 and is PERMIT_PACKAGE=Yes
> > >
> > > I see, when it seems that I had too pesimistic view for the world.
> > >
> >
> > I reviewed the port fallout1-ce. It works here, but only with the
> > included CFLAGS=-O1 -pipe, which bugs me that it's not clear why -O2
> > crashes. I'm attaching the backtrace from the corefile, in case
> > anyone can make sense why only O2+ crashes here.
> >
> > In general, it's probably easier to figure out the open questions
> > for one of the ports first, rather than discussing both together.
> > Once we got it sorted out, knowing how to deal with the other port
> > will probably be more straightforward, given the similarities.
> >
> > Regarding the other issues that have been raised:
> >
> > 1) I'm in favor of CATEGORIES=games x11, as it puts the most
> > relevant category first.
> >
> > 2) I don't have an opinion on fpattern as a port. For sake of moving
> > things along, I'd suggest that we consider importing fallout1-ce
> > with the bundled fpattern first. We can later see after a possible
> > fpattern port about using that rather than the bundled one.
> >
> > 3) README is clear enough for me as is.
> >
> > 4) We should be able to do just PERMIT_PKG=Yes like
> > games/devilutionx which has the same license.
> >
> > From my side ok thfr@ to import fallout1-ce, with the change to
> > CATEGORIES in 1).
>
> Attached is a cleaned up fallout1-ce port with the above suggestions,
> as well as me added as a maintainer as I forgot to add myself
> there earlier.
>
>

Ping!

--
iz (she/her)

> i like to say mundane things,
> there are too many uninteresting things
> that go unnoticed.

izder456 (dot) neocities (dot) org

No comments:

Post a Comment