On 02/11 10:53, Rafael Sadowski wrote:
> On Thu Feb 05, 2026 at 05:44:41PM -0800, Jeremy Evans wrote:
> > Simple update to the latest release of puma. Remove some files from the
> > PLIST that were added by mistake in the last update.
>
> Which files and why there are wrong?
Files in ${GEM_EXTENSIONS_DIR} and ${GEM_LIB}/gems/${DISTNAME}/ext.
These aren't necessary for the package. I'm not positive they cause any
issues with the currently supported Ruby versions, but historically,
which files were created in these directories can vary by Ruby version.
Additionally, unnecessary files bloat the package size. Unless it's
actually used by the library, files in these directories shouldn't be
added to the package. Additionally, the files in
${GEM_LIB}/gems/${DISTNAME}/docs/jungle/rc.d were marked with @rcscript,
which I assume is also incorrect.
ruby-module(5) explains this:
"""
Additionally, for gem ports with C
extensions, make update-plist will add back files used by the specific
FLAVOR (such as files under the extension source directory), which may
not exist for other FLAVORs, so always manually check the result of make
update-plist and manually test that all supported FLAVORs are buildable
before committing. Additionally, for gems with C extensions, make
update-plist may add back the extension source files, which shouldn't be
included in the files, so make sure to double check that all files added
by make update-plist should be included in the package
"""
If you think the instructions here should be more explicit, please let
me know and I can update them.
Best,
Jeremy
>
> >
> > Will be committing in a couple days unless I hear objections.
> >
> > Thanks,
> > Jeremy
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/www/ruby-puma/Makefile,v
> > retrieving revision 1.17
> > diff -u -p -u -p -r1.17 Makefile
> > --- Makefile 4 Jul 2025 06:33:10 -0000 1.17
> > +++ Makefile 6 Feb 2026 01:43:33 -0000
> > @@ -1,6 +1,6 @@
> > COMMENT = simple, fast, threaded webserver for rack applications
> >
> > -DISTNAME = puma-6.6.0
> > +DISTNAME = puma-7.2.0
> > CATEGORIES = www
> >
> > HOMEPAGE = https://puma.io/
> > Index: distinfo
> > ===================================================================
> > RCS file: /cvs/ports/www/ruby-puma/distinfo,v
> > retrieving revision 1.13
> > diff -u -p -u -p -r1.13 distinfo
> > --- distinfo 4 Jul 2025 06:33:10 -0000 1.13
> > +++ distinfo 6 Feb 2026 01:43:33 -0000
> > @@ -1,2 +1,2 @@
> > -SHA256 (puma-6.6.0.gem) = 8lwGhz6z1d5fCk68eDrMgaTM/lgMdgz+MjSXeYAYrYc=
> > -SIZE (puma-6.6.0.gem) = 238080
> > +SHA256 (puma-7.2.0.gem) = v470q1FKTm1FVMtDJrIATrpQNq4Fz3Zc/lGrqXBqcqg=
> > +SIZE (puma-7.2.0.gem) = 246272
> > Index: pkg/PLIST
> > ===================================================================
> > RCS file: /cvs/ports/www/ruby-puma/pkg/PLIST,v
> > retrieving revision 1.12
> > diff -u -p -u -p -r1.12 PLIST
> > --- pkg/PLIST 4 Jul 2025 06:33:10 -0000 1.12
> > +++ pkg/PLIST 6 Feb 2026 01:43:33 -0000
> > @@ -1,10 +1,6 @@
> > ${GEM_BIN}/puma${GEM_BIN_SUFFIX}
> > ${GEM_BIN}/pumactl${GEM_BIN_SUFFIX}
> > ${GEM_LIB}/cache/${DISTNAME}.gem
> > -${GEM_EXTENSIONS_DIR}/gem_make.out
> > -${GEM_EXTENSIONS_DIR}/mkmf.log
> > -${GEM_EXTENSIONS_DIR}/puma/
> > -@so ${GEM_EXTENSIONS_DIR}/puma/puma_http11.so
> > ${GEM_LIB}/gems/${DISTNAME}/
> > ${GEM_LIB}/gems/${DISTNAME}/History.md
> > ${GEM_LIB}/gems/${DISTNAME}/LICENSE
> > @@ -26,9 +22,6 @@ ${GEM_LIB}/gems/${DISTNAME}/docs/java_op
> > ${GEM_LIB}/gems/${DISTNAME}/docs/jungle/
> > ${GEM_LIB}/gems/${DISTNAME}/docs/jungle/README.md
> > ${GEM_LIB}/gems/${DISTNAME}/docs/jungle/rc.d/
> > -@rcscript ${GEM_LIB}/gems/${DISTNAME}/docs/jungle/rc.d/README.md
> > -@rcscript ${GEM_LIB}/gems/${DISTNAME}/docs/jungle/rc.d/puma
> > -@rcscript ${GEM_LIB}/gems/${DISTNAME}/docs/jungle/rc.d/puma.conf
> > ${GEM_LIB}/gems/${DISTNAME}/docs/kubernetes.md
> > ${GEM_LIB}/gems/${DISTNAME}/docs/nginx.md
> > ${GEM_LIB}/gems/${DISTNAME}/docs/plugins.md
> > @@ -39,32 +32,6 @@ ${GEM_LIB}/gems/${DISTNAME}/docs/stats.m
> > ${GEM_LIB}/gems/${DISTNAME}/docs/systemd.md
> > ${GEM_LIB}/gems/${DISTNAME}/docs/testing_benchmarks_local_files.md
> > ${GEM_LIB}/gems/${DISTNAME}/docs/testing_test_rackup_ci_files.md
> > -${GEM_LIB}/gems/${DISTNAME}/ext/
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/.sitearchdir.-.puma.time
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/Makefile
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/PumaHttp11Service.java
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/ext_help.h
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/extconf.rb
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/http11_parser.c
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/http11_parser.h
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/http11_parser.java.rl
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/http11_parser.o
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/http11_parser.rl
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/http11_parser_common.rl
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/mini_ssl.c
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/mini_ssl.o
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/no_ssl/
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/no_ssl/PumaHttp11Service.java
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/org/
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/org/jruby/
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/org/jruby/puma/
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/org/jruby/puma/Http11.java
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/org/jruby/puma/Http11Parser.java
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/org/jruby/puma/MiniSSL.java
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/puma_http11.c
> > -${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/puma_http11.o
> > -@so ${GEM_LIB}/gems/${DISTNAME}/ext/puma_http11/puma_http11.so
> > ${GEM_LIB}/gems/${DISTNAME}/lib/
> > ${GEM_LIB}/gems/${DISTNAME}/lib/puma/
> > ${GEM_LIB}/gems/${DISTNAME}/lib/puma.rb
> > @@ -77,6 +44,7 @@ ${GEM_LIB}/gems/${DISTNAME}/lib/puma/clu
> > ${GEM_LIB}/gems/${DISTNAME}/lib/puma/cluster.rb
> > ${GEM_LIB}/gems/${DISTNAME}/lib/puma/cluster/worker.rb
> > ${GEM_LIB}/gems/${DISTNAME}/lib/puma/cluster/worker_handle.rb
> > +${GEM_LIB}/gems/${DISTNAME}/lib/puma/cluster_accept_loop_delay.rb
> > ${GEM_LIB}/gems/${DISTNAME}/lib/puma/commonlogger.rb
> > ${GEM_LIB}/gems/${DISTNAME}/lib/puma/configuration.rb
> > ${GEM_LIB}/gems/${DISTNAME}/lib/puma/const.rb
> >
No comments:
Post a Comment