On 26/03/2026 12:48 am, Larry Moore wrote:
> On 25/03/2026 11:55 pm, Stuart Henderson wrote:
>> On 2026/03/25 15:46, Stuart Henderson wrote:
>>> There are some things I'm not too sure about but will be easier to work
>>> with smaller diffs for that
>>
>> I don't see how these cmdlen-related changes can do anything,
>>
>> - cmdlen++; /* Include NUL character */
>> + if (cmdlen > 0) cmdlen++; /* Include NUL
>> character */
>>
>> they're all snprintf to a static buffer and all have a non empty format
>> string, so doesn't seem it can ever be hit. I think removing would make
>> sense, do you agree?
>>
Hi Stuart,
Removing these patches did not introduce any noticeable behavioural changes.
You may delete them.
Cheers,
Larry.
No comments:
Post a Comment