Thursday, March 19, 2026

Re: Update: Ruby 4.0.2

On 03/18 07:01, Jeremy Evans wrote:
> On 03/18 11:23, Stuart Henderson wrote:
> > On 2026/03/16 23:30, Jeremy Evans wrote:
> > > +SITES.rubygems = https://github.com/ruby/rubygems/commit/
> > > +PATCHFILES.rubygems = ruby402-gem-fix{60e7365256ddd055b3cc59a28c2288b37ad6bf29}.patch
> >
> > those commit patch files on github aren't particularly stable (in
> > particular the length of truncated hashes can change in the file).
> > I'd prefer to just add it as a normal patch (I think just the
> > lib/rubygems.rb one would be enough?)
>
> I can switch to that. However, we use this distpatch pattern in a number
> of other places. We are already using it for another patch in this port:
>
> PATCHFILES.p = ruby-box-test-fix{099da884fe95ccf6c684a1563ed1c4b0fd8e1196}.patch
>
> SITES.p comes from lang/ruby/Makefile.inc:
>
> SITES.p ?= https://github.com/ruby/ruby/commit/
>
> So using a similar approach for this rubygems patch seems reasonable to
> me. I also expect this distpatch to only be needed temporarily, it's
> likely Ruby 4.0.3 will include it.
>
> Considering that, would you still prefer the distpatch be replaced with
> a normal patch?

I committed this using the distpatch approach. If you'd like me to
switch to the normal patch approach, please let me know and I'll do
that.

Best,
Jeremy

No comments:

Post a Comment