Hi,
thanks for all the feedback, I addressed all those concerns.
I din't figured how to trigger the Meson to install everything properly. As far as I could tell, there isn't a proper install target?
Therefore, as this port is so simple, just mirrored what the Makefile is doing in a do-install: target.
With that, no patches needed.
updated version attached.
cheers,
Sebastian
On Tue, Jun 23, 2026 at 12:16 PM Stuart Henderson <stu@spacehopper.org> wrote:
On 2026/06/23 03:44, Anthony J. Bentley wrote:
> Sebastian Reitenbach writes:
> > kids have fun playing super silly games, to prevent them from ruining their
> > hands and mouse, they'd rather use xclicker ;)
> >
> > cat pkg/DESCR
> > XClicker is an open-source, easy to use, feature-rich, blazing fast
> > Autoclicker for desktops using x11.
> ^-- should be lowercase "autoclicker"
it's very marketing-blurb-y too. how about
XClicker automatically simulates mouse clicks with your choice of mouse
button at pre-chosen or random intervals.
> Fails to build without sudo installed and configured. sudo should be
> patched out.
just skip the Makefile completely, see below
> License marker in Makefile should say "GPLv3 only".
>
> 'make update-plist' will trim a line from PLIST.
>
: VERSION = 1.5.1
: GH_ACCOUNT = robiot
: GH_PROJECT = XClicker
: GH_TAGNAME = v${VERSION}
: DISTNAME = xclicker-${VERSION}
: ...
: WRKDIST = ${WRKDIR}/xclicker-${VERSION}
having to override WRKDIST on a GH_* port is usually a sign something is
wrong with the distfile name setup. (with GH_TAGNAME you generally do
not want to override DISTNAME except in cases with special chars).
in this case you can replace all the above with
GH_ACCOUNT = robiot
GH_PROJECT = xclicker
GH_TAGNAME = v1.5.1
because the github project is already supposed to be all-lowercase.
no need to set PKGNAME, the default is ok. (make show=PKGNAMES).
(had the gh project actually been XClicker, the usualy option would be
the above + PKGNAME=${DISTNAME:L}).
: CATEGORIES = x11
trailing space
: BUILD_DEPENDS = devel/meson
when building meson-based ports you should use MODULES=devel/meson
where possible because it does a bunch of extra setup. drop USE_GMAKE
and ALL_TARGET, and write a do-install target to install those 3 files.
: CONFIGURE_STYLE = none
drop this
--
No comments:
Post a Comment