På onsdag 8. juli 2026 kl. 02:19, skrev Matthew <fiddle@disroot.org>: > On 06/22/26 01:26PM, Anthony J. Bentley wrote: > > Thanks for submitting this, and sorry it took so long for a response. > > Some comments: > > > > - Missing dep on graphics/shaderc. > > - USE_WXNEEDED and USE_NOBTCFI need a comment explaining what the > > problem is. And bug reports should be filed upstream so they know > > that there's interest in JITs that use branch target instructions > > and W^X memory. > > - This port would definitely benefit from enabling debug packages. > > - License marker should say "GPLv3 only" or "GPLv3+" rather than "GPLv3". > > Ditto for LGPLv3. > > - stdlib.h is the only header for malloc() and alloca() on Unix systems. > > The #ifdef blocks in pcsx2/GS/Renderers/HW/GSTextureCache.cpp and > > common/VectorIntrin.h should be replaced entirely upstream with just > > #include <stdlib.h>. > > - 3rdparty/rapidyaml/include/c4/yml/common.hpp should be upstreamed as: > > #if defined(C4_MSVC) || defined(C4_MINGW) || defined(_WIN32) || defined(C4_WIN) > > #include <malloc.h> > > #else > > #include <stdlib.h> > >
No comments:
Post a Comment