On Thu, Jul 02, 2026 at 09:09:57PM +0000, Johannes Thyssen Tishman wrote: > 2026-07-02T13:19:30+0100 Stuart Henderson <stu@spacehopper.org>: > > On 2026/07/02 14:14, Theo Buehler wrote: > > > On Wed, Jul 01, 2026 at 04:38:25PM +0000, Johannes Thyssen Tishman wrote: > > > > 2026-06-20T13:54:47+0000 Johannes Thyssen Tishman <jtt@openbsd.org>: > > > > > Please find below an update for graphics/coin to version 4.0.9. > > > > > > > > > > Changelog: https://github.com/coin3d/coin/releases/tag/v4.0.9 > > > > > > > > > > Notes about this update: > > > > > 1. Enable tests: 100% tests passed, 0 tests failed out of 1 > > > > > 2. No shared library bump needed as there were no dynamic export > > > > > changes. > > > > > > The value of an enum changed (math is hard). This often requires > > > a major bump (see below): > > > > good catch! > > Thanks for the review sthen and also to you tb for taking the time and > noticing this. Lesson learned that bumps are not to be fully based on > the output of check_sym. May I ask how you noticed this? Changelog? > Recursive diff between source tarballs? With coin 4.0.8 installed and 4.0.9 built till fake (which I need for make check-shlib-syms anyway) I simply did: diff -r /usr/local/include/ /usr/ports/pobj/coin-4.0.9/fake-amd64/usr/local/include/ This diff happens to be tiny in this update and the iffy enum change jumped out. If I want to be more careful I might also 'make extract' the current version before updating (or applying a diff) and look at the diff between the old and the new WRKSRC. It takes a bit of practice to know what to look at and what to look for.
No comments:
Post a Comment