On 7/27/26 21:14, Thomas Frohwein wrote: > On Sat, 25 Jul 2026 18:24:57 -0400 > Brad Smith <brad@comstyle.com> wrote: > >> Within the last few months recoil-rts has gained support for building >> on aarch64. The following diff fixes building the port on aarch64. > > Thanks, Brad. This is a fairly big port and I'm reluctant to enable it > for arm64 without reports on the test suite (`make test`) and runtime. > With the below diff, you can check if the math is correct from upstream. https://github.com/beyond-all-reason/RecoilEngine/blob/master/.github/workflows/streflop-float-test.yml This is what I get on amd64 here (RESULT: BIT-EXACT MATCH): cd /mnt/ext/_ports/pobj/recoil-rts-2026.06.12/RecoilEngine-2026.06.12 && python3 ./tools/sync-test/compare_results.py ./tools/sync-test/reference/streflop_results_NEON_arm64.bin /mnt/ext/_ports/pobj/recoil-rts-2026.06.12/build-amd64/results.`uname -m`.bin Reference: ./tools/sync-test/reference/streflop_results_NEON_arm64.bin Test: /mnt/ext/_ports/pobj/recoil-rts-2026.06.12/build-amd64/results.amd64.bin Reference: STREFLOP_NEON on arm64 (52,080 tests) Test: STREFLOP_SSE on x86_64 (52,080 tests) ============================================================ COMPARISON SUMMARY ============================================================ Common tests: 52,080 Matching: 52,080 (100.0%) Mismatched: 0 (0.0%) NaN-both: 71 (counted as match) RESULT: BIT-EXACT MATCH cd /mnt/ext/_ports/pobj/recoil-rts-2026.06.12/RecoilEngine-2026.06.12 && python3 ./tools/sync-test/compare_results.py ./tools/sync-test/reference/streflop_results_SSE_x86_64.bin /mnt/ext/_ports/pobj/recoil-rts-2026.06.12/build-amd64/results.`uname -m`.bin Reference: ./tools/sync-test/reference/streflop_results_SSE_x86_64.bin Test: /mnt/ext/_ports/pobj/recoil-rts-2026.06.12/build-amd64/results.amd64.bin Reference: STREFLOP_SSE on x86_64 (47,852 tests) Test: STREFLOP_SSE on x86_64 (52,080 tests) WARNING: Different test counts (ref=47,852, test=52,080) Comparing first 47,852 records ============================================================ COMPARISON SUMMARY ============================================================ Common tests: 47,852 Matching: 47,852 (100.0%) Mismatched: 0 (0.0%) RESULT: BIT-EXACT MATCH -- Fabien Romano Index: Makefile =================================================================== RCS file: /mnt/ext/cvs/ports/games/recoil-rts/Makefile,v diff -u -p -r1.28 Makefile --- Makefile 24 Jul 2026 03:46:16 -0000 1.28 +++ Makefile 27 Jul 2026 21:40:42 -0000 @@ -136,4 +136,18 @@ post-install: ${SUBST_PROGRAM} ${FILESDIR}/beyond-all-reason \ ${PREFIX}/bin/beyond-all-reason +# hack to run streflop-float-test +do-configure: + @${MODCMAKE_configure} -S ${WRKSRC}/tools/sync-test -DSTREFLOP_MODE=SSE +do-build: + @${MODCMAKE_BUILD_TARGET} -t streflop-float-test +do-test: + cd ${WRKBUILD} && ./streflop-float-test -n 10000 results.`uname -m` + cd ${WRKSRC} && python3 ./tools/sync-test/compare_results.py \ + ./tools/sync-test/reference/streflop_results_NEON_arm64.bin \ + ${WRKBUILD}/results.`uname -m`.bin + cd ${WRKSRC} && python3 ./tools/sync-test/compare_results.py \ + ./tools/sync-test/reference/streflop_results_SSE_x86_64.bin \ + ${WRKBUILD}/results.`uname -m`.bin + .include <bsd.port.mk>
No comments:
Post a Comment