Tuesday, September 15, 2026

mail/aerc: msgviewer: fix slice aliasing when setting pager.Env

Hello ports@ This is a cherry-picked 0.22.0 regression fix. See this conversation: https://lists.sr.ht/~rjarry/aerc-devel/patches/71385 Andrew diff --git a/mail/aerc/Makefile b/mail/aerc/Makefile index 0f615de7a..144db3f7b 100644 --- a/mail/aerc/Makefile +++ b/mail/aerc/Makefile @@ -8,7 +8,7 @@ MODGO_VERSION = v0.0.0-20260728163848-c2f86b7abde3 V = 0.22.0 DISTNAME = aerc-$V -REVISION = 0 +REVISION = 1 CATEGORIES = mail diff --git a/mail/aerc/patches/patch-app_msgviewer_go b/mail/aerc/patches/patch-app_msgviewer_go new file mode 100644 index 000000000..21b105bd6 --- /dev/null +++ b/mail/aerc/patches/patch-app_msgviewer_go @@ -0,0 +1,17 @@ +Cherry-pick 0.22.0 regression fix from upstream +commit: ab2f77e18953bf41e203679d920890ed9afc8611 + +Index: app/msgviewer.go +--- app/msgviewer.go.orig ++++ app/msgviewer.go +@@ -567,7 +567,9 @@ func NewPartViewer( + filter.Env = append(filter.Env, "AERC_OSC8_URLS=1") + } + if pager != filter { +- pager.Env = filter.Env ++ // Careful for slice aliasing here. Additional ++ // environment variable may be appended later. ++ pager.Env = filter.Env[:len(filter.Env):len(filter.Env)] + } + if pager == filter { + log.Debugf("<%s> part=%v %s: %v",

No comments:

Post a Comment