Re: xfce4: pass --enable-debug only when DEBUG is set

Le Sat, Dec 31, 2022 at 12:22:47PM +0000, Klemens Nanni a écrit :
> xfc4-wavelan spams ~/.xsession with state changes which stems from the
> xfce DBG macro which gets defined when the DEBUG macro is set, which
> comes from --enable-debug that is currently passed for every port using
> XFCE_COMMIT.
>
> landry pointed out the XFCE_COMMIT/--enable-debug connection and
> suggested a DEBUG test -- I failed to look at xfce4.port.mk in the first
> place.
>
> Only four ports use a commit, so bumping them is easy to pick up
> potential object changes.
>
> Feeback? Objection? OK?

I've had a second look at what --enable-maintainer-mode does and it's
still a bit fuzzy to me, but orage port builds fine without it. So i'd
completely move the CONFIGURE_ARGS line adding --enable-maintainer-mode
--enable-debug to the .if defined(DEBUG) block outside of the .if
defined(XFCE_COMMIT) block, this way all ports can be built with debug
macros enable via make DEBUG=-g.

Dunno if it's a good idea though to link that behaviour it to the ports
framework DEBUG variable, but we cant add --enable-debug to
DEBUG_CONFIGURE_ARGS since it'd enable debug macros globally &
inconditionally.

i had another look at --enable-debug in aclocal.m4 which is used in all
xfce projects, from
https://gitlab.xfce.org/xfce/xfce4-dev-tools/-/blob/master/m4macros/xdt-features.m4#L61:
- it also enables some -W flags too, some might lead to build failures
- the DBG macros are enabled for yes/full in the enable-debug values (eg no|minimum|yes|full, minimum being the
default)

Landry

Re: aarch64 bulk build report

On 2022 Dec 31 (Sat) at 14:22:24 -0700 (-0700), phessler@openbsd.org wrote:
:http://build-failures.rhaalovely.net/aarch64/2022-12-29/devel/quirks.log

actually built, not a real error


:http://build-failures.rhaalovely.net/aarch64/2022-12-29/games/naev,-data.log

Run-time dependency libenet found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency libenet

../../../obj/ports/naev-0.10.0/naev-0.10.0/meson.build:95:3: ERROR: Automatic wrap-based subproject downloading is disabled

A full log can be found at /usr/obj/ports/naev-0.10.0/build-aarch64/meson-logs/meson-log.txt
WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.


seems to be a missing dependency


:http://build-failures.rhaalovely.net/aarch64/2022-12-29/sysutils/py-filelock,python3.log

* Getting build dependencies for wheel...

ERROR Missing dependencies:
hatch-vcs>=0.3


missing dependency


:http://build-failures.rhaalovely.net/aarch64/2022-12-29/textproc/catfish.log

===> Faking installation for catfish-4.16.4p3
Traceback (most recent call last):
File "/usr/obj/ports/catfish-4.16.4/catfish-4.16.4/./setup.py", line 260, in <module>
DistUtilsExtra.auto.setup(
File "/usr/local/lib/python3.10/site-packages/DistUtilsExtra/auto.py", line 98, in setup
__requires(attrs, src_all)
File "/usr/local/lib/python3.10/site-packages/DistUtilsExtra/auto.py", line 471, in __requires
__add_imports(imports, s, attrs)
File "/usr/local/lib/python3.10/site-packages/DistUtilsExtra/auto.py", line 405, in __add_imports
if alias.name and __external_mod(cur_module, alias.name, attrs):
File "/usr/local/lib/python3.10/site-packages/DistUtilsExtra/auto.py", line 377, in __external_mod
return 'dist-packages' in mod.__file__ or 'site-packages' in mod.__file__ or \
TypeError: argument of type 'NoneType' is not iterable


:
:recurrent failures
:new failures
:+++ ls-failures Sat Dec 31 14:22:24 2022
:+failures/devel/quirks.log
:+failures/games/naev,-data.log
:+failures/sysutils/py-filelock,python3.log
:+failures/textproc/catfish.log
:resolved failures
:--- ../old/aarch64/last//ls-failures Tue Dec 27 09:44:25 2022
:

--
Pity the meek, for they shall inherit the earth.
-- Don Marquis