Re: net/ncftp: update with -fno-common

Charlene Wendling <julianaito@posteo.jp> writes:

> Hi,
>
> The fix has been taken from FreeBSD [0]. With that i can build and run
> ncftp without issues on amd64. While here, i moved HOMEPAGE to https.
>
> OK?

OK gnezdo

>
> Charlène.
>
>
> [0] https://github.com/freebsd/freebsd-ports/commit/3f1dcac7
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/ncftp/Makefile,v
> retrieving revision 1.47
> diff -u -p -u -p -r1.47 Makefile
> --- Makefile 10 Mar 2020 03:31:45 -0000 1.47
> +++ Makefile 31 Jan 2021 21:07:48 -0000
> @@ -4,8 +4,8 @@ COMMENT= FTP client with advanced user i
>
> DISTNAME= ncftp-3.2.6
> CATEGORIES= net
> -HOMEPAGE= http://www.ncftp.com/ncftp/
> -REVISION= 1
> +HOMEPAGE= https://www.ncftp.com/ncftp/
> +REVISION= 2
>
> # Artistic
> PERMIT_PACKAGE= Yes
> Index: patches/patch-sh_util_gpshare_c
> ===================================================================
> RCS file: patches/patch-sh_util_gpshare_c
> diff -N patches/patch-sh_util_gpshare_c
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-sh_util_gpshare_c 31 Jan 2021 21:07:48 -0000
> @@ -0,0 +1,16 @@
> +$OpenBSD$
> +
> +Fix -fno-common build failure.
> +
> +Index: sh_util/gpshare.c
> +--- sh_util/gpshare.c.orig
> ++++ sh_util/gpshare.c
> +@@ -28,7 +28,7 @@
> +
> + static int gIsAtty1 = 1, gIsAtty2 = 1;
> + extern int gLoadedBm, gBookmarkMatchMode;
> +-Bookmark gBm;
> ++extern Bookmark gBm;
> +
> + double
> + FileSize(double size, const char **uStr0, double *uMult0)