Stuart Henderson <stu@spacehopper.org> wrote:
> On 2022/03/01 12:00, Volker Schlecht wrote:
> >
> >
> > On 3/1/22 10:56, Omar Polo wrote:
> >
> > > live with the fact that it can't find jester and zip/zipfiles (we
> > > don't have them in the port tree, right?)
> >
> > They are probably part of the project's CI setup or otherwise popular enough
> > for all of the developers to have them somewhere in their ~/.nimble
> > directories :)
oh right, they're nim libraries, silly me
> > > + --parallelBuild:${MAKE_JOBS}
> >
> > Enforcing a "1" here actually increased the number of passing tests for me.
> > Not counting the ones I proposed to disable in my original patch, I'm down
> > to one single failure, for which I opened an issue with upstream:
> >
> > https://github.com/nim-lang/Nim/issues/19573
cool! while you're at it, would you mind trying to upstream the
patch for build.sh? the one for test(1) -eq vs = and the missing
$ sigil and quoting. I haven't looked into it but it seems to be
a generated script from some other file, and it probably affects
other OSes too.
> I think 1 is probably a good idea for tests, I didn't check nim but it
> usually aids diffability between multiple runs
agreed. i'll commit the diff with the parallelBuild changed back
to one if nobody complains
thanks
Omar Polo
No comments:
Post a Comment