Re: [new] graphics/pixelorama: pixel art editor

Please rename the distfile using the {} syntax of DISTFILES (see
bsd.port.mk(5) or crib from another port), having a file named icon.png in
the common distfiles directory is not ideal

--
Sent from a phone, apologies for poor formatting.

On 13 June 2022 05:41:48 Yifei Zhan <openbsd@zhan.science> wrote:

> On 22/06/12 10:43AM, mazzurco.riccardo wrote:
>> Hi,
>> I attached a new port for Pixelorama -
>> https://orama-interactive.itch.io/pixelorama
>> From the DESCR:
>>
>
> Looks interesting to me :)
>
> A few tweaks:
>
> - The built in .desktop file sets Icon=icon.png, this won't work
> because that file doesn't exist. I tweaked Makefile to fetch the
> icon file from the upstream repo and install it before setting up
> .desktop file:
>
> MASTER_SITES =
> https://github.com/Orama-Interactive/Pixelorama/releases/download/v$V/
> MASTER_SITES0 =
> https://github.com/Orama-Interactive/Pixelorama/raw/v$V/Misc/Clickable/click/
> DISTFILES = ${DISTNAME}{Pixelorama.Linux-64bit}${EXTRACT_SUFX} \
> icon.png:0
>
> EXTRACT_ONLY = ${DISTNAME}${EXTRACT_SUFX}
>
> ---cut---
>
> ${INSTALL_DATA_DIR} ${PREFIX}/share/pixmaps/
> ${INSTALL_DATA} ${FULLDISTDIR}/icon.png
> ${PREFIX}/share/pixmaps/pixelorama.png
> ${SUBST_DATA} ${FILESDIR}/pixelorama.desktop \
> ${PREFIX}/share/applications/pixelorama.desktop
>
> - .desktop file is modified to use the correct path:
>
> Icon=${TRUEPREFIX}/share/pixmaps/pixelorama.png
>
> - This port is tested on amd64 (the only supported arch, as this port
> uses pre-compiled file), works fine for me.
>
> - Formatting change for consistency.