Re: [update] net/knot and net/py-libknot to 3.2.0

On 8/23/22 20:29, Jeremie Courreges-Anglas wrote:
> On Tue, Aug 23 2022, Jeremie Courreges-Anglas <jca@wxcvbn.org> wrote:
>> On Tue, Aug 23 2022, aisha <openbsd.ports@aisha.cc> wrote:
>>> On 8/23/2022 7:20 AM, Jeremie Courreges-Anglas wrote:
>>>> On Mon, Aug 22 2022, aisha <openbsd.ports@aisha.cc> wrote:
>>>>> Hi,
>>>> Hi,
>>>>
>>>>> I've attached an update to net/knot and net/py-libknot to 3.2.0.
>>>>> A few library bumps, libknot has a symbol removed so updated its major
>>>>> version, libdnssec hasn't had any removals, I only see a few new ones,
>>>>> so I updated its minor. A second look at libdnssec would be useful.
>>>> libdnssec started to use new symbols from libc but doesn't export any
>>>> new symbols per se, so a minor bump isn't needed. I have tweaked that
>>>> before committing..
>>>>
>>>> One thing that I noticed in the configure output: there is now support
>>>> for DNS over QUIC using libngtcp2.
>>>>
>>>> +checking for libngtcp2 = 0.7.0 libngtcp2_crypto_gnutls... no
>>>> [...]
>>>> + DoQ support: no
>>>>
>>>> We don't have a port for ngtcp2 (https://github.com/ngtcp2/ngtcp2/) yet,
>>>> but I suspect we will and it would be good to prevent knot from picking
>>>> up that lib in bulk builds.
>>>>
>>>> ok for the diff below?
>>> I've been playing around with QUIC on other servers, so maybe I can port
>>> ngtcp2 over the weekend. In which case it might be better to add the
>>> ngtcp2 as a dependency for knot.
>> I have started working on a port yesterday evening, let me clean it up.
> Well, before cleaning up this port I got curious and looked what
> happened if I specified --enable-quic. In that case an embedded copy of
> ngtcp2 is built, but the knot code fails to build with this error:
>
> utils/common/netio.c:343:34: error: use of undeclared identifier 'IP_RECVTOS'
> if (setsockopt(fd, IPPROTO_IP, IP_RECVTOS, &tos, sizeof(tos)) == -1) {
>
> We don't have IP_RECVTOS. It's useful to peek at the ECN bits on UDP
> sockets. Adding it to our kernel looked trivial but while adding it
> I fell into a rabbit hole trying to understand what happened with IP_TTL
> and IP_RECVTTL... (looks like we copied the FreeBSD code which passed
> userland IP_RECVTTL cmsgs to userland instead of IP_TTL).
>

I found the freebsd commit for adding IP_RECVTOS -
https://github.com/freebsd/freebsd-src/commit/3cca425b2916f7d7b2ed9e757c2ab48b99843044

I don't know how useful that is, I have very little experience on the
network layer. Thanks for looking into it.

On the other hand, I've pinged knot developers about the issue, maybe
they have some other solution.

Thanks,
Aisha