Saturday, October 29, 2022

Re: [new] shells/nushell

> with ${COMPILER_LIBCXX}, make port-lib-depends-check complains about an
> extra "c++", another rust port I looked at have c++abi, adding it make
> port-lib-depends-check happy (in addition to other libs used)

I guess that's fine then.

> > in addition to what you have.
> >
> > Under ${WRKBUILD}/target/release there are a few binaries (plugins) and
> > libraries that you will probably want to install as well.
>
> I couldn't find them, I took a look in the subdirectories but nothing
> seemed useful there. Maybe I should let cargo do the "do-install" step?
> I skipped this because it was very long and I originally only wanted
> the shell binary.

That's because you dropped 'MODCARGO_BUILD_ARGS = --workspace' from the
Makefile:

With your previous tarball I got various nu_plugin_*, and the following
binaries: grid nu nu_pretty_hex ps table utils

I'll happily review this version carefully if you think those aren't
needed, but I suspect it's better to ship the complete thing.

No comments:

Post a Comment