Re: [new] shells/nushell

Le Sat, 29 Oct 2022 21:02:54 +0200,
Theo Buehler <tb@theobuehler.org> a écrit :

> On Sat, Oct 29, 2022 at 07:07:52PM +0200, Solène Rapenne wrote:
> > hi,
> >
> > this is a port for the shell nushell (non POSIX)
> >
> > - https://www.nushell.sh/
> >
> > It's my first Rust port, I took example from other, especially for the
> > line MODCARGO_CRATES_UPDATE
> >
> > tested on amd64, works fine
>
> I've only given it a quick look. At least devel/libgit2/libgit2 should
> be added as an LDEP.

indeed, I added it in the new tarball

> All rust binaries link against c++abi and pthread, you'll want at least
>
> WANTLIB += ${COMPILER_LIBCXX} crypto m pthread ssl

with ${COMPILER_LIBCXX}, make port-lib-depends-check complains about an
extra "c++", another rust port I looked at have c++abi, adding it make
port-lib-depends-check happy (in addition to other libs used)

> in addition to what you have.
>
> Under ${WRKBUILD}/target/release there are a few binaries (plugins) and
> libraries that you will probably want to install as well.

I couldn't find them, I took a look in the subdirectories but nothing
seemed useful there. Maybe I should let cargo do the "do-install" step?
I skipped this because it was very long and I originally only wanted
the shell binary.

solene@fx6 nushell 2$ ls -l /build/pobj/nushell-0.70.0/build-amd64/target/release/
total 59492
drwxr-xr-x 122 _pbuild _pbuild 4608 Oct 29 21:34 build
drwxr-xr-x 2 _pbuild _pbuild 45568 Oct 29 22:24 deps
drwxr-xr-x 2 _pbuild _pbuild 512 Oct 29 21:34 examples
drwxr-xr-x 2 _pbuild _pbuild 512 Oct 29 21:34 incremental
-rwxr-xr-x 2 _pbuild _pbuild 30361008 Oct 29 22:24 nu
-rw-r--r-- 1 _pbuild _pbuild 42982 Oct 29 22:24 nu.d

> 'make port-lib-depends-check'
>
> will then help getting WANTLIB and dependencies right.

oh right, I forgot about it, I became a bit... Rusty =D