Re: new www/shiori

On Tue, Aug 08, 2023 at 04:01:17PM +0200, Paco Esteban wrote:
>
> Find attached the updated version that removes the wrapper script and
> makes use of login classes.
>

one question:

in pkg/README, you have the example
# rcctl set shiori flags -a 0.0.0.0 -p 1234

and in pkg/shiori.rc, the default daemon_flags value is "serve -a localhost"

if I properly understand thecommand-line, 'serve' is a command which is required
to be passed for the service.

if you don't want to have to pass it systematically (rcctl set shiori flags serve -a 0.0.0.0 -p 1234),
maybe the following will work:

pkg/shiori.rc
-daemon="${TRUEPREFIX}/bin/shiori"
+daemon="${TRUEPREFIX}/bin/shiori serve"
daemon_user="_shiori"
-daemon_flags="serve -a localhost"
+daemon_flags="-a localhost"

thanks.
--
Sebastien Marie