Stuart Henderson wrote: > On 2026/06/11 16:55, Stuart Cassoff wrote: >> On Thu, 11 Jun 2026, Chris Billington wrote: >> >>> The present databases/sqlite3-tcl port is built with MODTCL_VERSION = 8.6, >>> producing /usr/local/lib/tcl/sqlite3/libsqlite3513.so >> >> >> With recent Tcl build systems and Tcl 9 we can build Tcl 8 extensions. >> This gives everything in one package, with the downside of two Tcl deps. >> >> >> Stu >> >> >> >> diff -Nurp /usr/ports/databases/sqlite3-tcl/Makefile ./Makefile >> --- /usr/ports/databases/sqlite3-tcl/Makefile Thu May 14 22:51:47 2026 >> +++ ./Makefile Thu Jun 11 09:30:11 2026 >> @@ -1,5 +1,7 @@ >> COMMENT = Tcl bindings for SQLite3 >> >> +REVISION = 0 >> + >> V = 3.53.0 >> >> DISTNAME = sqlite${V} >> @@ -19,11 +21,13 @@ SITES = ${SITE_SOURCEFORGE:=tcl/} >> DISTFILES = tclsqlite{sqlite}${V}${EXTRACT_SUFX} >> >> MODULES = lang/tcl >> -MODTCL_VERSION = 8.6 >> +MODTCL_VERSION = 9 >> >> BUILD_DEPENDS = ${MODTCL_BUILD_DEPENDS} >> -RUN_DEPENDS = ${MODTCL_RUN_DEPENDS} >> >> +RUN_DEPENDS = ${MODTCL_RUN_DEPENDS} \ >> + lang/tcl/8.6 >> + >> FAKE_FLAGS = PKG_DIR=sqlite3 >> SEPARATE_BUILD = Yes >> CONFIGURE_STYLE = gnu >> @@ -45,5 +49,13 @@ VER = ${V:S/.//g} >> >> pre-configure: >> @${MODTCL_TCLSH_ADJ} ${WRKSRC}/compat/sqlite3/spaceanal.tcl >> + >> +post-install: >> + cd ${WRKBUILD} && umask 022 && exec \ >> + env -i ${MAKE_ENV} ${MAKE_PROGRAM} ${MAKE_FLAGS} \ >> + -f ${MAKE_FILE} clean ${ALL_TARGET} \ >> + CPPFLAGS='-DTCL_MAJOR_VERSION=8' \ >> + PKG_LIB_FILE=libsqlite${VER}.so >> + ${INSTALL_DATA} ${WRKBUILD}/libsqlite${VER}.so ${DESTDIR}${MODTCL_TCLDIR}/sqlite3/ > > I'm not the biggest fan of a build stage in post-install, but it's > probably better than other options here. > > nitpicking, but could you indent the lines after \ please? > > post-install: > cd ${WRKBUILD} && umask 022 && exec \ > env -i ${MAKE_ENV} ${MAKE_PROGRAM} ${MAKE_FLAGS} \ > -f ${MAKE_FILE} clean ${ALL_TARGET} \ > CPPFLAGS='-DTCL_MAJOR_VERSION=8' \ > PKG_LIB_FILE=libsqlite${VER}.so > ${INSTALL_DATA} ${WRKBUILD}/libsqlite${VER}.so ${DESTDIR}${MODTCL_TCLDIR}/sqlite3/ > > ok > If the formatting could be corrected, would anyone like to give a second OK? Chris
No comments:
Post a Comment